Add AudioReceiveStream::SetGain() method and use that in WVoMC::SetOutputVolume().

Add AudioReceiveStream::SetGain() method and use that in WVoMC::SetOutputVolume().

Removes the need to use VoEVolume::SetChannelOutputVolumeScaling().

BUG=webrtc:4690
Committed: https://crrev.com/217fb66e16627be23b8769edded8a23f6406ddab
Cr-Commit-Position: refs/heads/master@{#13194}

[the sun, 2016-06-14 18:54:02]

Description was changed from

==========
Add AudioReceiveStream::SetGain() method and use that in
WVoMC::SetOutputVolume().

BUG=webrtc:4690
==========

to

==========
Add AudioReceiveStream::SetGain() method and use that in
WVoMC::SetOutputVolume().

Removes the need to use VoEVolume::SetChannelOutputVolumeScaling().

BUG=webrtc:4690
==========

[the sun, 2016-06-14 18:54:16]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2016-06-16 09:26:53]

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream_unittest.cc (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream_unittest.cc:100: .Times(1);
Ummm... am I missing something, or is this hunk just a reformatting with no
other changes?

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
File webrtc/audio_receive_stream.h (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
webrtc/audio_receive_stream.h:128: // is potentially forwarded to any attached
AudioSinkInterface implementation.
What gain is in effect prior to this method being called? And what unit or
similar does the gain number have?

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:2219: << " for recv channel with ssrc "
<< ssrc;
"recv stream"?

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3143: EXPECT_DOUBLE_EQ(3,
GetRecvStream(kSsrc2).gain());
Add an EXPECT_ to test the value of .gain() before the volume has been set?

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/test/mock_voe_chan...
File webrtc/test/mock_voe_channel_proxy.h (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/test/mock_voe_chan...
webrtc/test/mock_voe_channel_proxy.h:48: // MOCK_METHOD1(SetSink,
void(std::unique_ptr<AudioSinkInterface> sink));
You need icky workarounds for methods that return move-only values, but I'm not
aware of any particular problems with move-only arguments. What errors do you
get?

[the sun, 2016-06-16 14:34:07]

Oops, I did it again, rebased+fixed comments. :(

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream_unittest.cc (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream_unittest.cc:100: .Times(1);
On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> Ummm... am I missing something, or is this hunk just a reformatting with no
> other changes?

Yes, sorry about that.

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
File webrtc/audio_receive_stream.h (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
webrtc/audio_receive_stream.h:128: // is potentially forwarded to any attached
AudioSinkInterface implementation.
On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> What gain is in effect prior to this method being called? And what unit or
> similar does the gain number have?

A gain is simply a factor to multiply with. It doesn't have a unit. Nominal gain
is usually (and in this specific case) 1.0.

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:2219: << " for recv channel with ssrc "
<< ssrc;
On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> "recv stream"?

Done.

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3143: EXPECT_DOUBLE_EQ(3,
GetRecvStream(kSsrc2).gain());
On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> Add an EXPECT_ to test the value of .gain() before the volume has been set?

Done.

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/test/mock_voe_chan...
File webrtc/test/mock_voe_channel_proxy.h (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/test/mock_voe_chan...
webrtc/test/mock_voe_channel_proxy.h:48: // MOCK_METHOD1(SetSink,
void(std::unique_ptr<AudioSinkInterface> sink));
On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> You need icky workarounds for methods that return move-only values, but I'm
not
> aware of any particular problems with move-only arguments. What errors do you
> get?

../../webrtc/test/mock_voe_channel_proxy.h:49:3: error: call to
implicitly-deleted copy constructor of
'std::__1::unique_ptr<webrtc::AudioSinkInterface,
std::__1::default_delete<webrtc::AudioSinkInterface> >'
  MOCK_METHOD1(SetSink, void(std::unique_ptr<AudioSinkInterface> sink));

(Since the change is orthogonal to this CL, I'll just leave it commented out for
now. I merely went through the methods and noticed this one missing.)

[kwiberg-webrtc, 2016-06-17 07:37:49]

On 2016/06/16 14:34:07, the sun wrote:
> Oops, I did it again, rebased+fixed comments. :(

Next time you can

  1. Delete the bad patch set from the web interface.
  2. (Make sure you don't have uncommitted changes in your tree.)
  3. git tag foo
  4. git reset --hard HEAD~1 (or however many commits you've made since the last
patch set)
  5. git cl upload  # rebase
  6. git reset --hard foo
  7. git cl upload  # the real change

[kwiberg-webrtc, 2016-06-17 07:38:54]

lgtm

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
File webrtc/audio_receive_stream.h (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
webrtc/audio_receive_stream.h:128: // is potentially forwarded to any attached
AudioSinkInterface implementation.
On 2016/06/16 14:34:06, the sun wrote:
> On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> > What gain is in effect prior to this method being called? And what unit or
> > similar does the gain number have?
> 
> A gain is simply a factor to multiply with. It doesn't have a unit. Nominal
gain
> is usually (and in this specific case) 1.0.

OK. If this is well known to everyone except me, I guess it doesn't need a
comment.

[the sun, 2016-06-17 08:48:54]

On 2016/06/17 07:37:49, kwiberg-webrtc wrote:
> On 2016/06/16 14:34:07, the sun wrote:
> > Oops, I did it again, rebased+fixed comments. :(
> 
> Next time you can
> 
>   1. Delete the bad patch set from the web interface.
>   2. (Make sure you don't have uncommitted changes in your tree.)
>   3. git tag foo
>   4. git reset --hard HEAD~1 (or however many commits you've made since the
last
> patch set)
>   5. git cl upload  # rebase
>   6. git reset --hard foo
>   7. git cl upload  # the real change

Ah, thanks!

[the sun, 2016-06-17 08:50:23]

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
File webrtc/audio_receive_stream.h (right):

https://codereview.webrtc.org/2062193002/diff/20001/webrtc/audio_receive_stre...
webrtc/audio_receive_stream.h:128: // is potentially forwarded to any attached
AudioSinkInterface implementation.
On 2016/06/17 07:38:54, kwiberg-webrtc wrote:
> On 2016/06/16 14:34:06, the sun wrote:
> > On 2016/06/16 09:26:53, kwiberg-webrtc wrote:
> > > What gain is in effect prior to this method being called? And what unit or
> > > similar does the gain number have?
> > 
> > A gain is simply a factor to multiply with. It doesn't have a unit. Nominal
> gain
> > is usually (and in this specific case) 1.0.
> 
> OK. If this is well known to everyone except me, I guess it doesn't need a
> comment.

Gain is a very common concept in audio engineering.

[the sun, 2016-06-17 08:52:52]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-06-17 08:52:52]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2062193002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2016-06-17 08:53:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062193002/60001

[commit-bot: I haz the power, 2016-06-17 09:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 09:23:15]

Try jobs failed on following builders:
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/15994)

[the sun, 2016-06-17 14:17:56]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-06-17 14:17:56]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2062193002/#ps80001 (title:
"bad test")

[commit-bot: I haz the power, 2016-06-17 14:18:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062193002/80001

[commit-bot: I haz the power, 2016-06-17 15:30:56]

Description was changed from

==========
Add AudioReceiveStream::SetGain() method and use that in
WVoMC::SetOutputVolume().

Removes the need to use VoEVolume::SetChannelOutputVolumeScaling().

BUG=webrtc:4690
==========

to

==========
Add AudioReceiveStream::SetGain() method and use that in
WVoMC::SetOutputVolume().

Removes the need to use VoEVolume::SetChannelOutputVolumeScaling().

BUG=webrtc:4690
==========

[commit-bot: I haz the power, 2016-06-17 15:30:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-17 15:31:04]

Description was changed from

==========
Add AudioReceiveStream::SetGain() method and use that in
WVoMC::SetOutputVolume().

Removes the need to use VoEVolume::SetChannelOutputVolumeScaling().

BUG=webrtc:4690
==========

to

==========
Add AudioReceiveStream::SetGain() method and use that in
WVoMC::SetOutputVolume().

Removes the need to use VoEVolume::SetChannelOutputVolumeScaling().

BUG=webrtc:4690

Committed: https://crrev.com/217fb66e16627be23b8769edded8a23f6406ddab
Cr-Commit-Position: refs/heads/master@{#13194}
==========

[commit-bot: I haz the power, 2016-06-17 15:31:06]

Patchset 5 (id:??) landed as
https://crrev.com/217fb66e16627be23b8769edded8a23f6406ddab
Cr-Commit-Position: refs/heads/master@{#13194}