Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Side by Side Diff: webrtc/audio_receive_stream.h

Issue 2062193002: Add AudioReceiveStream::SetGain() method and use that in WVoMC::SetOutputVolume(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: misc Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // Sets an audio sink that receives unmixed audio from the receive stream. 117 // Sets an audio sink that receives unmixed audio from the receive stream.
118 // Ownership of the sink is passed to the stream and can be used by the 118 // Ownership of the sink is passed to the stream and can be used by the
119 // caller to do lifetime management (i.e. when the sink's dtor is called). 119 // caller to do lifetime management (i.e. when the sink's dtor is called).
120 // Only one sink can be set and passing a null sink clears an existing one. 120 // Only one sink can be set and passing a null sink clears an existing one.
121 // NOTE: Audio must still somehow be pulled through AudioTransport for audio 121 // NOTE: Audio must still somehow be pulled through AudioTransport for audio
122 // to stream through this sink. In practice, this happens if mixed audio 122 // to stream through this sink. In practice, this happens if mixed audio
123 // is being pulled+rendered and/or if audio is being pulled for the purposes 123 // is being pulled+rendered and/or if audio is being pulled for the purposes
124 // of feeding to the AEC. 124 // of feeding to the AEC.
125 virtual void SetSink(std::unique_ptr<AudioSinkInterface> sink) = 0; 125 virtual void SetSink(std::unique_ptr<AudioSinkInterface> sink) = 0;
126 126
127 // Sets playback gain of the stream, applied when mixing, and thus after it
128 // is potentially forwarded to any attached AudioSinkInterface implementation.
kwiberg-webrtc 2016/06/16 09:26:53 What gain is in effect prior to this method being
the sun 2016/06/16 14:34:06 A gain is simply a factor to multiply with. It doe
kwiberg-webrtc 2016/06/17 07:38:54 OK. If this is well known to everyone except me, I
the sun 2016/06/17 08:50:23 Gain is a very common concept in audio engineering
129 virtual void SetGain(float gain) = 0;
130
127 protected: 131 protected:
128 virtual ~AudioReceiveStream() {} 132 virtual ~AudioReceiveStream() {}
129 }; 133 };
130 } // namespace webrtc 134 } // namespace webrtc
131 135
132 #endif // WEBRTC_AUDIO_RECEIVE_STREAM_H_ 136 #endif // WEBRTC_AUDIO_RECEIVE_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698