Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: webrtc/media/engine/webrtcvoiceengine_unittest.cc

Issue 2062193002: Add AudioReceiveStream::SetGain() method and use that in WVoMC::SetOutputVolume(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: bad test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/test/mock_voe_channel_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine_unittest.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine_unittest.cc b/webrtc/media/engine/webrtcvoiceengine_unittest.cc
index 167ec89267e63381d8fcd1738324d013d2d8484f..2db70d1521758ecb27c56aec3add98ca058740f0 100644
--- a/webrtc/media/engine/webrtcvoiceengine_unittest.cc
+++ b/webrtc/media/engine/webrtcvoiceengine_unittest.cc
@@ -3130,24 +3130,20 @@ TEST_F(WebRtcVoiceEngineTestFake, SetOutputVolume) {
cricket::StreamParams stream;
stream.ssrcs.push_back(kSsrc2);
EXPECT_TRUE(channel_->AddRecvStream(stream));
- int channel_id = voe_.GetLastChannel();
+ EXPECT_DOUBLE_EQ(1, GetRecvStream(kSsrc2).gain());
EXPECT_TRUE(channel_->SetOutputVolume(kSsrc2, 3));
- float scale = 0;
- EXPECT_EQ(0, voe_.GetChannelOutputVolumeScaling(channel_id, scale));
- EXPECT_DOUBLE_EQ(3, scale);
+ EXPECT_DOUBLE_EQ(3, GetRecvStream(kSsrc2).gain());
}
TEST_F(WebRtcVoiceEngineTestFake, SetOutputVolumeDefaultRecvStream) {
EXPECT_TRUE(SetupChannel());
EXPECT_TRUE(channel_->SetOutputVolume(0, 2));
DeliverPacket(kPcmuFrame, sizeof(kPcmuFrame));
- int channel_id = voe_.GetLastChannel();
- float scale = 0;
- EXPECT_EQ(0, voe_.GetChannelOutputVolumeScaling(channel_id, scale));
- EXPECT_DOUBLE_EQ(2, scale);
+ EXPECT_DOUBLE_EQ(2, GetRecvStream(1).gain());
EXPECT_TRUE(channel_->SetOutputVolume(0, 3));
- EXPECT_EQ(0, voe_.GetChannelOutputVolumeScaling(channel_id, scale));
- EXPECT_DOUBLE_EQ(3, scale);
+ EXPECT_DOUBLE_EQ(3, GetRecvStream(1).gain());
+ EXPECT_TRUE(channel_->SetOutputVolume(1, 4));
+ EXPECT_DOUBLE_EQ(4, GetRecvStream(1).gain());
}
TEST_F(WebRtcVoiceEngineTestFake, SetsSyncGroupFromSyncLabel) {
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/test/mock_voe_channel_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698