Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: webrtc/modules/media_file/media_file_impl.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/media_file/media_file_impl.cc
diff --git a/webrtc/modules/media_file/media_file_impl.cc b/webrtc/modules/media_file/media_file_impl.cc
index 27fe9613a3ba8ab8833a2b0833946262303aebdb..9f9511d837ea6dfe424f38834628ee23e9be552e 100644
--- a/webrtc/modules/media_file/media_file_impl.cc
+++ b/webrtc/modules/media_file/media_file_impl.cc
@@ -371,12 +371,11 @@ int32_t MediaFileImpl::StartPlayingAudioFile(
return -1;
}
- if(inputStream->OpenFile(fileName, true, loop) != 0)
- {
- delete inputStream;
- WEBRTC_TRACE(kTraceError, kTraceFile, _id,
- "Could not open input file %s", fileName);
- return -1;
+ if (!inputStream->OpenFile(fileName, true)) {
+ delete inputStream;
+ WEBRTC_TRACE(kTraceError, kTraceFile, _id, "Could not open input file %s",
+ fileName);
+ return -1;
}
if(StartPlayingStream(*inputStream, loop, notificationTimeMs,
@@ -748,13 +747,11 @@ int32_t MediaFileImpl::StartRecordingAudioFile(
return -1;
}
- if(outputStream->OpenFile(fileName, false) != 0)
- {
- delete outputStream;
- WEBRTC_TRACE(kTraceError, kTraceFile, _id,
- "Could not open output file '%s' for writing!",
- fileName);
- return -1;
+ if (!outputStream->OpenFile(fileName, false)) {
+ delete outputStream;
+ WEBRTC_TRACE(kTraceError, kTraceFile, _id,
+ "Could not open output file '%s' for writing!", fileName);
+ return -1;
}
if(maxSizeBytes)
« no previous file with comments | « webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc ('k') | webrtc/modules/media_file/media_file_utility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698