Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc
diff --git a/webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc b/webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc
index 3e202bf088c61fdf7bb64d03c722e21eb632d3c9..3b08314d3be2440a2754a5d0401ec9ecf96c6def 100644
--- a/webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc
+++ b/webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc
@@ -95,12 +95,9 @@ TEST(WPDTreeTest, CorrectnessBasedOnMatlabFiles) {
std::ostringstream matlab_stream;
matlab_stream << "audio_processing/transient/wpd" << i;
std::string matlab_string = test::ResourcePath(matlab_stream.str(), "dat");
- matlab_files_data[i]->OpenFile(matlab_string.c_str(),
- true, // Read only.
- false, // No loop.
- false); // No text.
+ matlab_files_data[i]->OpenFile(matlab_string.c_str(), true); // Read only.
- bool file_opened = matlab_files_data[i]->Open();
+ bool file_opened = matlab_files_data[i]->is_open();
ASSERT_TRUE(file_opened) << "File could not be opened.\n" << matlab_string;
// Out files.
@@ -110,12 +107,9 @@ TEST(WPDTreeTest, CorrectnessBasedOnMatlabFiles) {
out_stream << test::OutputPath() << "wpd_" << i << ".out";
std::string out_string = out_stream.str();
- out_files_data[i]->OpenFile(out_string.c_str(),
- false, // Write mode.
- false, // No loop.
- false); // No text.
+ out_files_data[i]->OpenFile(out_string.c_str(), false); // Write mode.
- file_opened = out_files_data[i]->Open();
+ file_opened = out_files_data[i]->is_open();
ASSERT_TRUE(file_opened) << "File could not be opened.\n" << out_string;
}
@@ -125,12 +119,9 @@ TEST(WPDTreeTest, CorrectnessBasedOnMatlabFiles) {
std::unique_ptr<FileWrapper> test_file(FileWrapper::Create());
- test_file->OpenFile(test_file_name.c_str(),
- true, // Read only.
- false, // No loop.
- false); // No text.
+ test_file->OpenFile(test_file_name.c_str(), true); // Read only.
- bool file_opened = test_file->Open();
+ bool file_opened = test_file->is_open();
ASSERT_TRUE(file_opened) << "File could not be opened.\n" << test_file_name;
float test_buffer[kTestBufferSize];
« no previous file with comments | « webrtc/modules/audio_processing/transient/transient_detector_unittest.cc ('k') | webrtc/modules/media_file/media_file_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698