webrtc/modules/audio_processing/transient/transient_detector_unittest.cc - Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/transient/transient_detector_unittest.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/transient/file_utils_unittest.cc ('k') | webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/transient/transient_detector_unittest.cc

diff --git a/webrtc/modules/audio_processing/transient/transient_detector_unittest.cc b/webrtc/modules/audio_processing/transient/transient_detector_unittest.cc

index 18bb42e0eb6739f17b227e7379165ef4588df8f1..fedddb7d8f98d0bc65eefe15c6d44f339c26727d 100644

--- a/webrtc/modules/audio_processing/transient/transient_detector_unittest.cc

+++ b/webrtc/modules/audio_processing/transient/transient_detector_unittest.cc

@@ -53,11 +53,9 @@ TEST(TransientDetectorTest, CorrectnessBasedOnFiles) {

detect_file->OpenFile(

test::ResourcePath(detect_file_name.str(), "dat").c_str(),

- true, // Read only.

- false, // No loop.

- false); // No text.

+ true); // Read only.

- bool file_opened = detect_file->Open();

+ bool file_opened = detect_file->is_open();

ASSERT_TRUE(file_opened) << "File could not be opened.\n"

<< detect_file_name.str().c_str();

@@ -70,9 +68,7 @@ TEST(TransientDetectorTest, CorrectnessBasedOnFiles) {

audio_file->OpenFile(

test::ResourcePath(audio_file_name.str(), "pcm").c_str(),

- true, // Read only.

- false, // No loop.

- false); // No text.

+ true); // Read only.

// Create detector.

TransientDetector detector(sample_rate_hz);