Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: webrtc/modules/media_file/media_file_utility.cc

Issue 2054373002: FileWrapper[Impl] modifications and actually remove the "Impl" class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix use of ASSERT instead of ASSERT_TRUE in test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/media_file/media_file_utility.cc
diff --git a/webrtc/modules/media_file/media_file_utility.cc b/webrtc/modules/media_file/media_file_utility.cc
index 8a815cc25d6c1f0ab4f480a95f0d265dedeeb43d..8e7c8f6a028383f890b57d6bbc65c6447088253e 100644
--- a/webrtc/modules/media_file/media_file_utility.cc
+++ b/webrtc/modules/media_file/media_file_utility.cc
@@ -1456,12 +1456,11 @@ int32_t ModuleFileUtility::FileDurationMs(const char* fileName,
"failed to create InStream object!");
return -1;
}
- if(inStreamObj->OpenFile(fileName, true) == -1)
- {
- delete inStreamObj;
- WEBRTC_TRACE(kTraceError, kTraceFile, _id,
- "failed to open file %s!", fileName);
- return -1;
+ if (!inStreamObj->OpenFile(fileName, true)) {
+ delete inStreamObj;
+ WEBRTC_TRACE(kTraceError, kTraceFile, _id, "failed to open file %s!",
+ fileName);
+ return -1;
}
switch (fileFormat)
« no previous file with comments | « webrtc/modules/media_file/media_file_impl.cc ('k') | webrtc/modules/video_coding/utility/ivf_file_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698