GN: Add SDK tests to rtc_unittests.

GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
NOTRY=True

Committed: https://crrev.com/3bcedd3595f417330149d661a8e4d4dd4b6562f8
Cr-Commit-Position: refs/heads/master@{#13060}

[kjellander_webrtc, 2016-06-06 19:01:31]

Description was changed from

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
==========

to

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
==========

[kjellander_webrtc, 2016-06-06 19:01:31]

kjellander@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[kjellander_webrtc, 2016-06-06 19:06:36]

Description was changed from

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
==========

to

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
NOTRY=True
==========

[kjellander_webrtc, 2016-06-06 19:34:03]

See comments in PS#1 and trybot results from PS#2+3 :)

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (left):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn#oldcode52
webrtc/base/BUILD.gn:52: "UIKit.framework",  # Already in
//build/config:default_libs.
No longer true.

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn#oldcode64
webrtc/base/BUILD.gn:64: libs = [ "Carbon.framework" ]  # Already in
//build/config:default_libs.
No longer true.

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn#newcode563
webrtc/base/BUILD.gn:563: "ApplicationServices.framework",
This seems to be implicitly added for the GYP build, but was needed for GN.

https://codereview.webrtc.org/2041743003/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (left):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/sdk/BUILD.gn#oldcode33
webrtc/sdk/BUILD.gn:33: "objc/Framework/Classes/RTCCameraPreviewView.m",
Just a few outdated entries, synced with the GYP build.

https://codereview.webrtc.org/2041743003/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/sdk/BUILD.gn#newcode190
webrtc/sdk/BUILD.gn:190: # TODO(tkchin): Add the rtc_sdk_framework_objc target.
Can you do this one?

https://codereview.webrtc.org/2041743003/diff/1/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (right):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/webrtc_tests.gypi#newc...
webrtc/webrtc_tests.gypi:194:
'sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm',
Including these here makes them execute as part of the rtc_unittests target.

[tkchin_webrtc, 2016-06-07 22:14:55]

lgtm

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn#newcode563
webrtc/base/BUILD.gn:563: "ApplicationServices.framework",
On 2016/06/06 19:34:03, kjellander_webrtc wrote:
> This seems to be implicitly added for the GYP build, but was needed for GN.

I don't know much about these frameworks, but if they are needed then they are
needed.

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:52: "UIKit.framework",
I feel like this isn't the best place to add these libs. Shouldn't the targets
that require them be the ones that specify them? But this is indeed the path of
least resistance because it would take a lot of time to track down which libs
require them.

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:187: # TODO(tkchin): Add the rtc_sdk_framework_objc target.
I'm not sure this builds correctly under GN. Did they add dynamic library
support for ObjC Framework targets?

[kjellander_webrtc, 2016-06-08 08:03:21]

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/1/webrtc/base/BUILD.gn#newcode563
webrtc/base/BUILD.gn:563: "ApplicationServices.framework",
On 2016/06/07 22:14:54, tkchin_webrtc wrote:
> On 2016/06/06 19:34:03, kjellander_webrtc wrote:
> > This seems to be implicitly added for the GYP build, but was needed for GN.
> 
> I don't know much about these frameworks, but if they are needed then they are
> needed.

Yepp, they are.

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:52: "UIKit.framework",
On 2016/06/07 22:14:54, tkchin_webrtc wrote:
> I feel like this isn't the best place to add these libs. Shouldn't the targets
> that require them be the ones that specify them? But this is indeed the path
of
> least resistance because it would take a lot of time to track down which libs
> require them.
> 

You're absolutely right, but I don't want to involve cleanup in this effort -
focus is on getting us over to GN first. Then we can iterate a lot faster with
such cleanups.

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:187: # TODO(tkchin): Add the rtc_sdk_framework_objc target.
On 2016/06/07 22:14:55, tkchin_webrtc wrote:
> I'm not sure this builds correctly under GN. Did they add dynamic library
> support for ObjC Framework targets?

I don't know much about that. Do you know a tracking bug that can be followed?
If not, could you file one?

[kjellander_webrtc, 2016-06-08 08:08:56]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-06-08 08:09:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041743003/40001

[commit-bot: I haz the power, 2016-06-08 08:14:20]

Description was changed from

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
NOTRY=True
==========

to

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
NOTRY=True
==========

[commit-bot: I haz the power, 2016-06-08 08:14:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 08:14:29]

Description was changed from

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
NOTRY=True
==========

to

==========
GN: Add SDK tests to rtc_unittests.

In https://codereview.webrtc.org/2034923003 it was discovered
that a test binary rtc_sdk_peerconnection_objc_tests was
a dependency to rtc_unittests. Unfortunately gtest doesn't
include dependent executables into the same test executable;
only libraries (so theses tests weren't run).

This CL incorporates those tests into rtc_unittests and
does the same changes to the GN build.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests locally on Mac.
NOTRY=True

Committed: https://crrev.com/3bcedd3595f417330149d661a8e4d4dd4b6562f8
Cr-Commit-Position: refs/heads/master@{#13060}
==========

[commit-bot: I haz the power, 2016-06-08 08:14:30]

Patchset 3 (id:??) landed as
https://crrev.com/3bcedd3595f417330149d661a8e4d4dd4b6562f8
Cr-Commit-Position: refs/heads/master@{#13060}

[Nico, 2016-06-13 11:32:34]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-06-13 11:32:34]

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:64: libs = [ "Carbon.framework" ]
This must be +=, not =, else gn will fail with "this overwrites a non-empty
list" when configuring a 32-bit build. Can you add a + here please?

(i'd do it myself, but editing webrtc as part of a chromium checkout and running
`git cl upload` there doesn't work, while it works fine for all other
third-party chromium deps. I do have a standalone webrtc checkout, but it's
still on webrtc, and getting a fresh standalone webrtc checkout will take hours
and I'm on a laptop and traveling…)

[kjellander_webrtc, 2016-06-13 11:51:33]

On 2016/06/13 11:32:34, Nico (traveling...slow) wrote:
> https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn
> File webrtc/base/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2041743003/diff/40001/webrtc/base/BUILD.gn#newc...
> webrtc/base/BUILD.gn:64: libs = [ "Carbon.framework" ]
> This must be +=, not =, else gn will fail with "this overwrites a non-empty
> list" when configuring a 32-bit build. Can you add a + here please?

Sure, doing it in https://codereview.webrtc.org/2065583002/

> 
> (i'd do it myself, but editing webrtc as part of a chromium checkout and
running
> `git cl upload` there doesn't work, while it works fine for all other
> third-party chromium deps. I do have a standalone webrtc checkout, but it's
> still on webrtc, and getting a fresh standalone webrtc checkout will take
hours
> and I'm on a laptop and traveling…)

Right, that's unfortunate and is tracked in
https://bugs.chromium.org/p/chromium/issues/detail?id=611808