GN: Add rtc_unittests

GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one actually doesn't make those tests run as part of rtc_unittests
(by design). Fixing that + add them will done in aseparate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).

R=perkj@webrtc.org

Committed: https://crrev.com/3ee5614650f7f85c16734c6d6133f19c4e815c91
Cr-Commit-Position: refs/heads/master@{#13036}

[kjellander_webrtc, 2016-06-03 12:10:35]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-06-03 12:11:47]

Description was changed from

==========
GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one doens't mean those tests are run as part of rtc_unittests
unfortunately (by design). Fixing that + add them will done in a
separate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).
==========

to

==========
GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one actually doesn't make those tests run as part of rtc_unittests
(by design). Fixing that + add them will done in aseparate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).
==========

[kjellander_webrtc, 2016-06-03 12:11:58]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[perkj_webrtc, 2016-06-03 13:44:59]

perkj@webrtc.org changed reviewers:
+ perkj@webrtc.org

[perkj_webrtc, 2016-06-03 13:45:00]

lgtm

[kjellander_webrtc, 2016-06-03 13:55:15]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-03 13:55:18]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2016-06-03 13:57:10]

Description was changed from

==========
GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one actually doesn't make those tests run as part of rtc_unittests
(by design). Fixing that + add them will done in aseparate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).
==========

to

==========
GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one actually doesn't make those tests run as part of rtc_unittests
(by design). Fixing that + add them will done in aseparate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).

R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3ee5614650f7f85c16734c6d6...
==========

[kjellander_webrtc, 2016-06-03 13:57:12]

Committed patchset #1 (id:20001) manually as
3ee5614650f7f85c16734c6d6133f19c4e815c91 (presubmit successful).

[commit-bot: I haz the power, 2016-06-03 14:19:02]

Description was changed from

==========
GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one actually doesn't make those tests run as part of rtc_unittests
(by design). Fixing that + add them will done in aseparate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).

R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3ee5614650f7f85c16734c6d6...
==========

to

==========
GN: Add rtc_unittests

Everything except the dependency on
sdk/sdk_tests.gyp:rtc_sdk_peerconnection_objc_tests is included.
That one actually doesn't make those tests run as part of rtc_unittests
(by design). Fixing that + add them will done in aseparate CL.

BUG=webrtc:5949
TESTED=Built and ran rtc_unittests on Mac.
Verified the number of tests matched a run on the bot (1213 tests executed).

R=perkj@webrtc.org

Committed: https://crrev.com/3ee5614650f7f85c16734c6d6133f19c4e815c91
Cr-Commit-Position: refs/heads/master@{#13036}
==========

[phoglund, 2016-06-03 14:28:56]

https://codereview.webrtc.org/2034923003/diff/20001/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/2034923003/diff/20001/webrtc/BUILD.gn#newcode387
webrtc/BUILD.gn:387: # come from a config and can"t be on the target directly.
Nit: ', not "

https://codereview.webrtc.org/2034923003/diff/20001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (left):

https://codereview.webrtc.org/2034923003/diff/20001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:140: 'sources!': [
Why is this in this cl?

[kjellander_webrtc, 2016-06-06 17:04:22]

https://codereview.webrtc.org/2034923003/diff/20001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (left):

https://codereview.webrtc.org/2034923003/diff/20001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:140: 'sources!': [
On 2016/06/03 14:28:56, phoglund wrote:
> Why is this in this cl?

I just cleaned up an entry that doesn't do anything, since I was reading this
GYP file when comparing the two.