Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: webrtc/base/BUILD.gn

Issue 2041743003: GN: Add SDK tests to rtc_unittests. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Final fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 7d2035db862e81b8b3d7cb3462719f7efe99acef..1fffbe858737ebb3cd95c32371c5903c66d3860f 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -49,7 +49,7 @@ config("rtc_base_all_dependent_config") {
#"Foundation.framework", # Already in //build/config:default_libs.
"Security.framework",
"SystemConfiguration.framework",
- "UIKit.framework", # Already in //build/config:default_libs.
+ "UIKit.framework",
tkchin_webrtc 2016/06/07 22:14:54 I feel like this isn't the best place to add these
kjellander_webrtc 2016/06/08 08:03:21 You're absolutely right, but I don't want to invol
]
}
if (is_mac) {
@@ -61,7 +61,7 @@ config("rtc_base_all_dependent_config") {
"SystemConfiguration.framework",
]
if (current_cpu == "x86") {
- libs = [ "Carbon.framework" ] # Already in //build/config:default_libs.
+ libs = [ "Carbon.framework" ]
Nico 2016/06/13 11:32:34 This must be +=, not =, else gn will fail with "th
}
}
}
@@ -558,7 +558,13 @@ static_library("rtc_base") {
"macutils.cc",
"macutils.h",
]
- libs += [ "CoreServices.framework" ] # For GetGestalt in macutils.cc.
+ libs += [
+ # For ProcessInformationCopyDictionary in unixfilesystem.cc.
+ "ApplicationServices.framework",
+
+ # For GetGestalt in macutils.cc.
+ "CoreServices.framework",
+ ]
}
if (is_win) {
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | webrtc/sdk/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698