Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2035593003: Re-enabling -Woverloaded-virtual. (Closed)

Created:
4 years, 6 months ago by phoglund
Modified:
4 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enabling -Woverloaded-virtual. We should build with this flag; some of our downstream users do. This was found necessary after a recent breakage was introduced with https://codereview.webrtc.org/1972793003. Verified by hand that this would have caught the above error. R=kjellander@webrtc.org CC=deadbeef@webrtc.org Committed: https://crrev.com/116e4d4faec0439d7bec53db547320d00015572c Cr-Commit-Position: refs/heads/master@{#13013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M webrtc/api/api.gyp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
phoglund
4 years, 6 months ago (2016-06-02 08:55:40 UTC) #1
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-06-02 09:07:13 UTC) #3
phoglund
4 years, 6 months ago (2016-06-02 10:26:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
116e4d4faec0439d7bec53db547320d00015572c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698