Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Side by Side Diff: webrtc/api/api.gyp

Issue 2035593003: Re-enabling -Woverloaded-virtual. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 ], 60 ],
61 # TODO(kjellander): Make the code compile without disabling these flag s. 61 # TODO(kjellander): Make the code compile without disabling these flag s.
62 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 62 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
63 'cflags': [ 63 'cflags': [
64 '-Wno-sign-compare', 64 '-Wno-sign-compare',
65 '-Wno-unused-variable', 65 '-Wno-unused-variable',
66 ], 66 ],
67 'cflags!': [ 67 'cflags!': [
68 '-Wextra', 68 '-Wextra',
69 ], 69 ],
70 'cflags_cc!': [
71 '-Woverloaded-virtual',
72 ],
73 'msvs_disabled_warnings': [ 70 'msvs_disabled_warnings': [
74 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch . 71 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch .
75 4267, # conversion from 'size_t' to 'int', possible loss of data. 72 4267, # conversion from 'size_t' to 'int', possible loss of data.
76 4389, # signed/unsigned mismatch. 73 4389, # signed/unsigned mismatch.
77 ], 74 ],
78 }, 75 },
79 { 76 {
80 'target_name': 'libjingle_peerconnection_so', 77 'target_name': 'libjingle_peerconnection_so',
81 'type': 'shared_library', 78 'type': 'shared_library',
82 'dependencies': [ 79 'dependencies': [
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 'webrtcsession.cc', 197 'webrtcsession.cc',
201 'webrtcsession.h', 198 'webrtcsession.h',
202 'webrtcsessiondescriptionfactory.cc', 199 'webrtcsessiondescriptionfactory.cc',
203 'webrtcsessiondescriptionfactory.h', 200 'webrtcsessiondescriptionfactory.h',
204 ], 201 ],
205 # TODO(kjellander): Make the code compile without disabling these flags. 202 # TODO(kjellander): Make the code compile without disabling these flags.
206 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 203 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
207 'cflags': [ 204 'cflags': [
208 '-Wno-sign-compare', 205 '-Wno-sign-compare',
209 ], 206 ],
210 'cflags_cc!': [
211 '-Woverloaded-virtual',
212 ],
213 'conditions': [ 207 'conditions': [
214 ['clang==1', { 208 ['clang==1', {
215 'cflags!': [ 209 'cflags!': [
216 '-Wextra', 210 '-Wextra',
217 ], 211 ],
218 'xcode_settings': { 212 'xcode_settings': {
219 'WARNING_CFLAGS!': ['-Wextra'], 213 'WARNING_CFLAGS!': ['-Wextra'],
220 }, 214 },
221 }, { 215 }, {
222 'cflags': [ 216 'cflags': [
(...skipping 28 matching lines...) Expand all
251 'quicdatatransport.h', 245 'quicdatatransport.h',
252 ], 246 ],
253 'export_dependent_settings': [ 247 'export_dependent_settings': [
254 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic', 248 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic',
255 ], 249 ],
256 }], 250 }],
257 ], 251 ],
258 }, # target libjingle_peerconnection 252 }, # target libjingle_peerconnection
259 ], # targets 253 ], # targets
260 } 254 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698