Use scoped_refptr for On(Add|Remove)Stream and OnDataChannel.

Use scoped_refptr for On(Add|Remove)Stream and OnDataChannel.

This will make it much less likely for application developers to not
realize the object is reference counted.

It also fixes a bug in the Java PeerConnection binding, by allowing a
reference to be transferred in the OnRemoveStream call via std::move.

BUG=webrtc:5128
R=pthatcher@webrtc.org, tkchin@webrtc.org

Committed: https://crrev.com/98cde26c7875497273f6bdde4b4dcb3e719386f2
Cr-Commit-Position: refs/heads/master@{#12976}

[Taylor Brandstetter, 2016-05-12 17:41:14]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, tkchin@webrtc.org

[Taylor Brandstetter, 2016-05-12 17:41:14]

Peter: Please take a look. This is something I've been wanting to do for a
while, since I've seen developers on discuss-webrtc forget to call AddRef and
then end up with the MediaStreamProxy or DataChannelProxy object being
destroyed, leading to confusing debugging.

As a happy coincidence, it also lets me fix an Android bug that many developers
have complained about.

Zeke: Can you review conductor.h/cc?

[tkchin_webrtc, 2016-05-12 17:50:23]

lgtm for conductor stuff

fwiw I didn't actually write any of that, but it seems like a simple enough
change.

https://codereview.webrtc.org/1972793003/diff/20001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/conductor.cc (right):

https://codereview.webrtc.org/1972793003/diff/20001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/conductor.cc:162:
main_wnd_->QueueUIThreadCallback(NEW_STREAM_ADDED, stream.release());
I haven't seen scoped_refptr used like this before, but I think it works.

[Taylor Brandstetter, 2016-05-12 17:52:34]

https://codereview.webrtc.org/1972793003/diff/20001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/conductor.cc (right):

https://codereview.webrtc.org/1972793003/diff/20001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/conductor.cc:162:
main_wnd_->QueueUIThreadCallback(NEW_STREAM_ADDED, stream.release());
On 2016/05/12 17:50:22, tkchin_webrtc wrote:
> I haven't seen scoped_refptr used like this before, but I think it works.

Yep; ".release()" is basically what you want to do when converting from a refptr
to a raw pointer which will be Released manually.

[pthatcher1, 2016-05-27 22:22:56]

lgtm

[Taylor Brandstetter, 2016-05-31 16:32:00]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-05-31 16:32:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972793003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972793003/20001

[commit-bot: I haz the power, 2016-05-31 18:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 18:13:24]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13765)

[Taylor Brandstetter, 2016-05-31 20:02:35]

Description was changed from

==========
Use scoped_refptr for On(Add|Remove)Stream and OnDataChannel.

This will make it much less likely for application developers to not
realize the object is reference counted.

It also fixes a bug in the Java PeerConnection binding, by allowing a
reference to be transferred in the OnRemoveStream call via std::move.

BUG=webrtc:5128
==========

to

==========
Use scoped_refptr for On(Add|Remove)Stream and OnDataChannel.

This will make it much less likely for application developers to not
realize the object is reference counted.

It also fixes a bug in the Java PeerConnection binding, by allowing a
reference to be transferred in the OnRemoveStream call via std::move.

BUG=webrtc:5128
R=pthatcher@webrtc.org, tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/98cde26c7875497273f6bdde4...
==========

[Taylor Brandstetter, 2016-05-31 20:02:37]

Committed patchset #2 (id:20001) manually as
98cde26c7875497273f6bdde4b4dcb3e719386f2 (presubmit successful).

[commit-bot: I haz the power, 2016-05-31 20:02:40]

Description was changed from

==========
Use scoped_refptr for On(Add|Remove)Stream and OnDataChannel.

This will make it much less likely for application developers to not
realize the object is reference counted.

It also fixes a bug in the Java PeerConnection binding, by allowing a
reference to be transferred in the OnRemoveStream call via std::move.

BUG=webrtc:5128
R=pthatcher@webrtc.org, tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/98cde26c7875497273f6bdde4...
==========

to

==========
Use scoped_refptr for On(Add|Remove)Stream and OnDataChannel.

This will make it much less likely for application developers to not
realize the object is reference counted.

It also fixes a bug in the Java PeerConnection binding, by allowing a
reference to be transferred in the OnRemoveStream call via std::move.

BUG=webrtc:5128
R=pthatcher@webrtc.org, tkchin@webrtc.org

Committed: https://crrev.com/98cde26c7875497273f6bdde4b4dcb3e719386f2
Cr-Commit-Position: refs/heads/master@{#12976}
==========