NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
NOTRY=true

Committed: https://crrev.com/342f74005fc47dc32555907a3eb07718fcb028a5
Cr-Commit-Position: refs/heads/master@{#13162}

[kwiberg-webrtc, 2016-06-01 11:52:35]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-06-01 12:55:17]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-06-01 13:49:21]

lgtm

https://codereview.webrtc.org/2027993002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/decoder_database.h (left):

https://codereview.webrtc.org/2027993002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/decoder_database.h:80: const
rtc::Optional<ExternalDecoder> external_decoder;
What?! No trailing underscore on the member variable? Who reviewed this?

[kwiberg-webrtc, 2016-06-01 13:55:33]

https://codereview.webrtc.org/2027993002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/decoder_database.h (left):

https://codereview.webrtc.org/2027993002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/decoder_database.h:80: const
rtc::Optional<ExternalDecoder> external_decoder;
On 2016/06/01 13:49:21, hlundin-webrtc wrote:
> What?! No trailing underscore on the member variable? Who reviewed this?

It appears to have been written and reviewed by two utter nincompoops. Luckily
for them, there's no way to find out who they were after all this time.

https://codereview.webrtc.org/2021063002

[kwiberg-webrtc, 2016-06-16 09:42:21]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-06-16 09:42:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2027993002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2016-06-16 09:42:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027993002/40001

[commit-bot: I haz the power, 2016-06-16 09:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 09:52:20]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14235)

[kwiberg-webrtc, 2016-06-16 10:01:19]

Description was changed from

==========
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
==========

to

==========
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
NOTRY=true
==========

[kwiberg-webrtc, 2016-06-16 10:02:09]

On 2016/06/16 09:52:20, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_dbg on tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14235)

Adding NOTRY=true to bypass android_dbg and android_arm64_rel, since those bots
appear to be broken.

[kwiberg-webrtc, 2016-06-16 10:02:17]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-06-16 10:02:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027993002/40001

[commit-bot: I haz the power, 2016-06-16 10:18:04]

Description was changed from

==========
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
NOTRY=true
==========

to

==========
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-16 10:18:05]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-16 10:18:17]

Description was changed from

==========
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
NOTRY=true
==========

to

==========
NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

BUG=webrtc:5801
NOTRY=true

Committed: https://crrev.com/342f74005fc47dc32555907a3eb07718fcb028a5
Cr-Commit-Position: refs/heads/master@{#13162}
==========

[commit-bot: I haz the power, 2016-06-16 10:18:18]

Patchset 2 (id:??) landed as
https://crrev.com/342f74005fc47dc32555907a3eb07718fcb028a5
Cr-Commit-Position: refs/heads/master@{#13162}