Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2029543002: AudioDecoder: Remove the default implementation of SampleRateHz (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@samprate0
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AudioDecoder: Remove the default implementation of SampleRateHz And implement SampleRateHz in a bunch of mocks. BUG=webrtc:5801 NOTRY=true Committed: https://crrev.com/347d35129ee61a4bce2fd732fdd2852e164257b2 Cr-Commit-Position: refs/heads/master@{#13161}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M webrtc/modules/audio_coding/codecs/audio_decoder.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_external_decoder_pcm16b.h View 3 chunks +11 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 6 chunks +10 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc View 4 chunks +10 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
kwiberg-webrtc
This can't land until I've sent out a PSA giving people ~two weeks to adapt, ...
4 years, 6 months ago (2016-06-01 12:54:35 UTC) #3
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-06-01 13:44:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029543002/40001
4 years, 6 months ago (2016-06-16 02:57:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8748)
4 years, 6 months ago (2016-06-16 03:17:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029543002/40001
4 years, 6 months ago (2016-06-16 06:39:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8750)
4 years, 6 months ago (2016-06-16 06:50:30 UTC) #13
kwiberg-webrtc
On 2016/06/16 06:50:30, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-16 08:57:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029543002/40001
4 years, 6 months ago (2016-06-16 08:57:47 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-16 08:59:13 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 08:59:20 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/347d35129ee61a4bce2fd732fdd2852e164257b2
Cr-Commit-Position: refs/heads/master@{#13161}

Powered by Google App Engine
This is Rietveld 408576698