Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2021063002: NetEq decoder database: Don't keep track of sample rate for builtin decoders (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@decoder-samp-rate
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq decoder database: Don't keep track of sample rate for builtin decoders This allows us to get rid of the function that computes it, which gets us one step closer to getting rid of the NetEqDecoder type. BUG=webrtc:5801 Committed: https://crrev.com/c0f2dcf9ed1ef3d528c29cb1e85ba29f7c3d56ef Cr-Commit-Position: refs/heads/master@{#12974}

Patch Set 1 #

Patch Set 2 : Remove illegal catch-all lambda captures #

Patch Set 3 : explicit capture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -198 lines) Patch
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 2 chunks +25 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.cc View 5 chunks +35 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database_unittest.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_audio_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 2 3 chunks +30 lines, -19 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/payload_splitter_unittest.cc View 5 chunks +10 lines, -19 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/timestamp_scaler_unittest.cc View 9 chunks +10 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
kwiberg-webrtc
4 years, 6 months ago (2016-05-30 14:01:21 UTC) #2
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-05-30 14:31:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021063002/20001
4 years, 6 months ago (2016-05-31 10:59:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/12432) win_rel on tryserver.webrtc (JOB_FAILED, ...
4 years, 6 months ago (2016-05-31 11:05:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021063002/40001
4 years, 6 months ago (2016-05-31 12:40:22 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 13:28:08 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 13:28:17 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c0f2dcf9ed1ef3d528c29cb1e85ba29f7c3d56ef
Cr-Commit-Position: refs/heads/master@{#12974}

Powered by Google App Engine
This is Rietveld 408576698