AudioDecoder: New method SampleRateHz, + implementations for our codecs

AudioDecoder: New method SampleRateHz, + implementations for our codecs

This will let NetEq (and the factory, and every layer in between) keep
track of just the decoder, instead of decoder and sample rate.

BUG=webrtc:5801
Committed: https://crrev.com/6c2eab34f8ff1f7a724622e3473858a4c0724bd8
Cr-Commit-Position: refs/heads/master@{#12968}

[kwiberg-webrtc, 2016-05-30 12:00:24]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-05-30 14:10:17]

LG, but I think you should hard-code PCM u/A to 8000 Hz.

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/audio_decoder.cc (right):

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/audio_decoder.cc:85: int
AudioDecoder::SampleRateHz() const {
Add a TODO to actually remove this implementation.

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h (right):

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h:22: explicit
AudioDecoderPcmU(int sample_rate_hz, size_t num_channels)
Even though not a technical necessity, I think PCM u/A are defined to be 8000 Hz
codecs. You should be able to hard-code 8000 Hz into these codecs and skip the
new ctor parameter.

[kwiberg-webrtc, 2016-05-31 08:26:05]

New patch set uploaded.

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/audio_decoder.cc (right):

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/audio_decoder.cc:85: int
AudioDecoder::SampleRateHz() const {
On 2016/05/30 14:10:17, hlundin-webrtc wrote:
> Add a TODO to actually remove this implementation.

Done.

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h (right):

https://codereview.webrtc.org/2024633002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h:22: explicit
AudioDecoderPcmU(int sample_rate_hz, size_t num_channels)
On 2016/05/30 14:10:17, hlundin-webrtc wrote:
> Even though not a technical necessity, I think PCM u/A are defined to be 8000
Hz
> codecs. You should be able to hard-code 8000 Hz into these codecs and skip the
> new ctor parameter.

Done.

[hlundin-webrtc, 2016-05-31 08:36:23]

lgtm

[kwiberg-webrtc, 2016-05-31 08:38:36]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-05-31 08:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024633002/20001

[commit-bot: I haz the power, 2016-05-31 09:46:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 09:46:32]

Description was changed from

==========
AudioDecoder: New method SampleRateHz, + implementations for our codecs

This will let NetEq (and the factory, and every layer in between) keep
track of just the decoder, instead of decoder and sample rate.

BUG=webrtc:5801
==========

to

==========
AudioDecoder: New method SampleRateHz, + implementations for our codecs

This will let NetEq (and the factory, and every layer in between) keep
track of just the decoder, instead of decoder and sample rate.

BUG=webrtc:5801

Committed: https://crrev.com/6c2eab34f8ff1f7a724622e3473858a4c0724bd8
Cr-Commit-Position: refs/heads/master@{#12968}
==========

[commit-bot: I haz the power, 2016-05-31 09:46:32]

Patchset 2 (id:??) landed as
https://crrev.com/6c2eab34f8ff1f7a724622e3473858a4c0724bd8
Cr-Commit-Position: refs/heads/master@{#12968}