Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2024573002: Revert of Android: Add FramerateRange class (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android: Add FramerateRange class (patchset #2 id:60001 of https://codereview.webrtc.org/2010763003/ ) Reason for revert: Breaks downstream Android tests: java.lang.NoSuchFieldError: no field with name='framerate' signature='org/webrtc/CameraEnumerationAndroid$CaptureFormat$FramerateRange' in class Lorg/webrtc/CameraEnumerationAndroid$CaptureFormat; We should have a similar test in WebRTC so we can catch such errors pre-commit. Original issue's description: > Android: Add FramerateRange class > > The Camera1 and Camera2 API use different framerate range types. Camera1 > uses int[2] and Camera2 uses Range<Integer>. Range<Integer> is > unfortunately only available on Lollipop and later, so this CL adds a > similar FramerateRange class in CaptureFormat. > > The purpose with this CL is to have a common framerate range type that can > be reused from both Camera1 and Camera2 in helper functions such as > CameraEnumerationAndroid.getClosestSupportedFramerateRange(). > > BUG=webrtc:5519 > R=sakal@webrtc.org > > Committed: https://crrev.com/94cb67d6df1a78e7fa25e469f719c1a8809dc583 > Cr-Commit-Position: refs/heads/master@{#12942} TBR=sakal@webrtc.org,magjed@webrtc.org NOTRY=True BUG=webrtc:5519 Committed: https://crrev.com/bd5621f065fd25e0a77307f10dc9ddaf76e7945f Cr-Commit-Position: refs/heads/master@{#12956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -102 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java View 4 chunks +24 lines, -55 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerator.java View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 2 chunks +11 lines, -16 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
Created Revert of Android: Add FramerateRange class
4 years, 6 months ago (2016-05-30 05:46:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024573002/1
4 years, 6 months ago (2016-05-30 06:01:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 06:06:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd5621f065fd25e0a77307f10dc9ddaf76e7945f Cr-Commit-Position: refs/heads/master@{#12956}
4 years, 6 months ago (2016-05-30 06:06:38 UTC) #8
magjed_webrtc
4 years, 6 months ago (2016-05-30 10:53:32 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2019333002/ by magjed@webrtc.org.

The reason for reverting is: Updated signature to work with other JNI versions..

Powered by Google App Engine
This is Rietveld 408576698