Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2019333002: Reland of Android: Add FramerateRange class (Closed)

Created:
4 years, 6 months ago by magjed_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android: Add FramerateRange class (patchset #1 id:1 of https://codereview.webrtc.org/2024573002/ ) Reason for revert: Updated signature to work with other JNI versions. We would need to compile it differently in order to catch failures like this in WebRTC in the future. Original issue's description: > Revert of Android: Add FramerateRange class (patchset #2 id:60001 of https://codereview.webrtc.org/2010763003/ ) > > Reason for revert: > Breaks downstream Android tests: > java.lang.NoSuchFieldError: no field with name='framerate' signature='org/webrtc/CameraEnumerationAndroid$CaptureFormat$FramerateRange' in class Lorg/webrtc/CameraEnumerationAndroid$CaptureFormat; > > We should have a similar test in WebRTC so we can catch such errors pre-commit. > > Original issue's description: > > Android: Add FramerateRange class > > > > The Camera1 and Camera2 API use different framerate range types. Camera1 > > uses int[2] and Camera2 uses Range<Integer>. Range<Integer> is > > unfortunately only available on Lollipop and later, so this CL adds a > > similar FramerateRange class in CaptureFormat. > > > > The purpose with this CL is to have a common framerate range type that can > > be reused from both Camera1 and Camera2 in helper functions such as > > CameraEnumerationAndroid.getClosestSupportedFramerateRange(). > > > > BUG=webrtc:5519 > > R=sakal@webrtc.org > > > > Committed: https://crrev.com/94cb67d6df1a78e7fa25e469f719c1a8809dc583 > > Cr-Commit-Position: refs/heads/master@{#12942} > > TBR=sakal@webrtc.org,magjed@webrtc.org > NOTRY=True > BUG=webrtc:5519 > > Committed: https://crrev.com/bd5621f065fd25e0a77307f10dc9ddaf76e7945f > Cr-Commit-Position: refs/heads/master@{#12956} TBR=sakal@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5519 Committed: https://crrev.com/e38a93663a69a7cd139d28c2c98bd5a32617254d Cr-Commit-Position: refs/heads/master@{#12957}

Patch Set 1 #

Patch Set 2 : Add L; to java class signature #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -47 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 1 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 4 chunks +55 lines, -24 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerator.java View 1 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 2 chunks +15 lines, -10 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
magjed_webrtc
Created Reland of Android: Add FramerateRange class
4 years, 6 months ago (2016-05-30 10:53:32 UTC) #1
magjed_webrtc
4 years, 6 months ago (2016-05-30 11:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019333002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019333002/180001
4 years, 6 months ago (2016-05-30 11:00:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:180001)
4 years, 6 months ago (2016-05-30 11:00:25 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e38a93663a69a7cd139d28c2c98bd5a32617254d Cr-Commit-Position: refs/heads/master@{#12957}
4 years, 6 months ago (2016-05-30 11:00:32 UTC) #9
kjellander_webrtc
4 years, 6 months ago (2016-05-30 12:00:13 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698