Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 2020343003: GN: Replace Windows suppressions of warning 4267 with config. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, peah-webrtc, zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, fengyue_agora.io, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, henrika_webrtc, mflodman, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Replace Windows suppressions of warning 4267 with config. This makes the GN configurations easier to read. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/8f4419b074b2869e178bb3bd178b8396e4417f3f Cr-Commit-Position: refs/heads/master@{#13006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -53 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/bitrate_controller/BUILD.gn View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +5 lines, -13 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-01 16:19:15 UTC) #2
phoglund
lgtm
4 years, 6 months ago (2016-06-02 08:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020343003/1
4 years, 6 months ago (2016-06-02 09:07:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:09:58 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:10:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f4419b074b2869e178bb3bd178b8396e4417f3f
Cr-Commit-Position: refs/heads/master@{#13006}

Powered by Google App Engine
This is Rietveld 408576698