Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: webrtc/modules/video_coding/BUILD.gn

Issue 2020343003: GN: Replace Windows suppressions of warning 4267 with config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/BUILD.gn ('k') | webrtc/system_wrappers/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 "timing.h", 68 "timing.h",
69 "video_coding_impl.cc", 69 "video_coding_impl.cc",
70 "video_coding_impl.h", 70 "video_coding_impl.h",
71 "video_receiver.cc", 71 "video_receiver.cc",
72 "video_sender.cc", 72 "video_sender.cc",
73 ] 73 ]
74 74
75 configs += [ "../..:common_config" ] 75 configs += [ "../..:common_config" ]
76 public_configs = [ "../..:common_inherited_config" ] 76 public_configs = [ "../..:common_inherited_config" ]
77 77
78 if (is_win) { 78 # TODO(jschuh): Bug 1348: fix this warning.
79 cflags = [ 79 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
80 # TODO(jschuh): Bug 1348: fix this warning.
81 "/wd4267", # size_t to int truncation.
82 ]
83 }
84 80
85 if (is_clang) { 81 if (is_clang) {
86 # Suppress warnings from Chrome's Clang plugins. 82 # Suppress warnings from Chrome's Clang plugins.
87 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 83 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
88 configs -= [ "//build/config/clang:find_bad_constructs" ] 84 configs -= [ "//build/config/clang:find_bad_constructs" ]
89 } 85 }
90 86
91 deps = [ 87 deps = [
92 ":video_coding_utility", 88 ":video_coding_utility",
93 ":webrtc_h264", 89 ":webrtc_h264",
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 "codecs/vp8/simulcast_encoder_adapter.cc", 252 "codecs/vp8/simulcast_encoder_adapter.cc",
257 "codecs/vp8/simulcast_encoder_adapter.h", 253 "codecs/vp8/simulcast_encoder_adapter.h",
258 "codecs/vp8/temporal_layers.h", 254 "codecs/vp8/temporal_layers.h",
259 "codecs/vp8/vp8_impl.cc", 255 "codecs/vp8/vp8_impl.cc",
260 "codecs/vp8/vp8_impl.h", 256 "codecs/vp8/vp8_impl.h",
261 ] 257 ]
262 258
263 configs += [ "../..:common_config" ] 259 configs += [ "../..:common_config" ]
264 public_configs = [ "../..:common_inherited_config" ] 260 public_configs = [ "../..:common_inherited_config" ]
265 261
262 # TODO(jschuh): Bug 1348: fix this warning.
263 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
264
266 if (is_clang) { 265 if (is_clang) {
267 # Suppress warnings from Chrome's Clang plugins. 266 # Suppress warnings from Chrome's Clang plugins.
268 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 267 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
269 configs -= [ "//build/config/clang:find_bad_constructs" ] 268 configs -= [ "//build/config/clang:find_bad_constructs" ]
270 } 269 }
271 270
272 if (is_win) {
273 cflags = [
274 # TODO(jschuh): Bug 1348: fix this warning.
275 "/wd4267", # size_t to int truncation.
276 ]
277 }
278
279 deps = [ 271 deps = [
280 ":video_coding_utility", 272 ":video_coding_utility",
281 "../..:webrtc_common", 273 "../..:webrtc_common",
282 "../../common_video", 274 "../../common_video",
283 "../../system_wrappers", 275 "../../system_wrappers",
284 ] 276 ]
285 if (rtc_build_libvpx) { 277 if (rtc_build_libvpx) {
286 deps += [ rtc_libvpx_dir ] 278 deps += [ rtc_libvpx_dir ]
287 } 279 }
288 } 280 }
(...skipping 20 matching lines...) Expand all
309 301
310 deps = [ 302 deps = [
311 ":video_coding_utility", 303 ":video_coding_utility",
312 "../../common_video", 304 "../../common_video",
313 "../../system_wrappers", 305 "../../system_wrappers",
314 ] 306 ]
315 if (rtc_build_libvpx) { 307 if (rtc_build_libvpx) {
316 deps += [ rtc_libvpx_dir ] 308 deps += [ rtc_libvpx_dir ]
317 } 309 }
318 } 310 }
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/BUILD.gn ('k') | webrtc/system_wrappers/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698