webrtc/modules/rtp_rtcp/BUILD.gn - Issue 2020343003: GN: Replace Windows suppressions of warning 4267 with config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/BUILD.gn

Issue 2020343003: GN: Replace Windows suppressions of warning 4267 with config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/BUILD.gn

diff --git a/webrtc/modules/rtp_rtcp/BUILD.gn b/webrtc/modules/rtp_rtcp/BUILD.gn

index b826fd1ea921b61668de1f6697975e1cd21e25f1..0f9dd8ad510a2740ed3e706ebd38af7839595b18 100644

--- a/webrtc/modules/rtp_rtcp/BUILD.gn

+++ b/webrtc/modules/rtp_rtcp/BUILD.gn

@@ -171,11 +171,11 @@ source_set("rtp_rtcp") {

"../remote_bitrate_estimator",

]

+ # TODO(jschuh): Bug 1348: fix this warning.

+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

if (is_win) {

cflags = [

- # TODO(jschuh): Bug 1348: fix this warning.

- "/wd4267", # size_t to int truncations

# TODO(kjellander): Bug 261: fix this warning.

"/wd4373", # virtual function override.

]

« no previous file with comments | « webrtc/modules/media_file/BUILD.gn ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »