Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010723002: [rtcp] Tmmbn/Tmmbr Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 7 months ago by danilchap
Modified:
4 years, 7 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] Tmmbn/Tmmbr Parse updated not to use RTCPUtility BUG=webrtc:5260 Committed: https://crrev.com/6ce1adc90b305ea0cba3676cf90604745954e36c Cr-Commit-Position: refs/heads/master@{#12916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -61 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn_unittest.cc View 7 chunks +6 lines, -14 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc View 6 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
åsapersson
lgtm
4 years, 7 months ago (2016-05-26 11:09:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010723002/1
4 years, 7 months ago (2016-05-26 11:23:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 12:29:19 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 12:29:28 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ce1adc90b305ea0cba3676cf90604745954e36c
Cr-Commit-Position: refs/heads/master@{#12916}

Powered by Google App Engine
This is Rietveld 408576698