Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h

Issue 2010723002: [rtcp] Tmmbn/Tmmbr Parse updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h
index 801aa085c44c855ea0fab3353899530df6fb3139..de1cf760bbaa64b52e57636713a66879af1412ca 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h
@@ -22,10 +22,10 @@ namespace rtcp {
// RFC4585, Section 6.2
class Rtpfb : public RtcpPacket {
public:
- static const uint8_t kPacketType = 205;
+ static constexpr uint8_t kPacketType = 205;
Rtpfb() : sender_ssrc_(0), media_ssrc_(0) {}
- virtual ~Rtpfb() {}
+ ~Rtpfb() override {}
void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }
void To(uint32_t ssrc) { media_ssrc_ = ssrc; }
@@ -34,7 +34,7 @@ class Rtpfb : public RtcpPacket {
uint32_t media_ssrc() const { return media_ssrc_; }
protected:
- static const size_t kCommonFeedbackLength = 8;
+ static constexpr size_t kCommonFeedbackLength = 8;
void ParseCommonFeedback(const uint8_t* payload);
void CreateCommonFeedback(uint8_t* payload) const;
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698