Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h

Issue 2010723002: [rtcp] Tmmbn/Tmmbr Parse updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBR_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBR_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBR_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBR_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/basictypes.h" 16 #include "webrtc/base/basictypes.h"
17 #include "webrtc/base/constructormagic.h" 17 #include "webrtc/base/constructormagic.h"
18 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h" 18 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h"
19 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmb_item.h" 19 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmb_item.h"
20 #include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
21 20
22 namespace webrtc { 21 namespace webrtc {
23 namespace rtcp { 22 namespace rtcp {
23 class CommonHeader;
24
24 // Temporary Maximum Media Stream Bit Rate Request (TMMBR). 25 // Temporary Maximum Media Stream Bit Rate Request (TMMBR).
25 // RFC 5104, Section 4.2.1. 26 // RFC 5104, Section 4.2.1.
26 class Tmmbr : public Rtpfb { 27 class Tmmbr : public Rtpfb {
27 public: 28 public:
28 static const uint8_t kFeedbackMessageType = 3; 29 static constexpr uint8_t kFeedbackMessageType = 3;
29 30
30 Tmmbr() {} 31 Tmmbr() {}
31 ~Tmmbr() override {} 32 ~Tmmbr() override {}
32 33
33 // Parse assumes header is already parsed and validated. 34 // Parse assumes header is already parsed and validated.
34 bool Parse(const RTCPUtility::RtcpCommonHeader& header, 35 bool Parse(const CommonHeader& packet);
35 const uint8_t* payload); // Size of the payload is in the header.
36 36
37 void WithTmmbr(const TmmbItem& item); 37 void WithTmmbr(const TmmbItem& item);
38 38
39 const std::vector<TmmbItem>& requests() const { return items_; } 39 const std::vector<TmmbItem>& requests() const { return items_; }
40 40
41 protected: 41 protected:
42 bool Create(uint8_t* packet, 42 bool Create(uint8_t* packet,
43 size_t* index, 43 size_t* index,
44 size_t max_length, 44 size_t max_length,
45 RtcpPacket::PacketReadyCallback* callback) const override; 45 RtcpPacket::PacketReadyCallback* callback) const override;
46 46
47 private: 47 private:
48 size_t BlockLength() const override { 48 size_t BlockLength() const override {
49 return kHeaderLength + kCommonFeedbackLength + 49 return kHeaderLength + kCommonFeedbackLength +
50 TmmbItem::kLength * items_.size(); 50 TmmbItem::kLength * items_.size();
51 } 51 }
52 52
53 // Media ssrc is unused, shadow base class setter and getter. 53 // Media ssrc is unused, shadow base class setter and getter.
54 void To(uint32_t ssrc); 54 void To(uint32_t ssrc);
55 uint32_t media_ssrc() const; 55 uint32_t media_ssrc() const;
56 56
57 std::vector<TmmbItem> items_; 57 std::vector<TmmbItem> items_;
58 58
59 RTC_DISALLOW_COPY_AND_ASSIGN(Tmmbr); 59 RTC_DISALLOW_COPY_AND_ASSIGN(Tmmbr);
60 }; 60 };
61 } // namespace rtcp 61 } // namespace rtcp
62 } // namespace webrtc 62 } // namespace webrtc
63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBR_H_ 63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBR_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698