Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1998183002: Clang format on AGC legacy code. (Closed)

Created:
4 years, 7 months ago by minyue-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clang format on AGC legacy code. BUG= Committed: https://crrev.com/cac94aae3e2eb749658c978f198e1ca7627ae972 Cr-Commit-Position: refs/heads/master@{#12831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1788 lines, -2013 lines) Patch
M webrtc/modules/audio_processing/agc/legacy/analog_agc.h View 1 chunk +82 lines, -83 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/analog_agc.c View 6 chunks +1061 lines, -1192 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/digital_agc.h View 2 chunks +32 lines, -33 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/digital_agc.c View 2 chunks +594 lines, -677 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/gain_control.h View 3 chunks +19 lines, -28 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
minyue-webrtc
Hi Henrik, This is a pure reformat on the AGC codes. It may not be ...
4 years, 7 months ago (2016-05-20 08:57:53 UTC) #3
hlundin-webrtc
lgtm peah@ suggest you may want to migrate to .cc files while you are at ...
4 years, 7 months ago (2016-05-20 09:04:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998183002/1
4 years, 7 months ago (2016-05-20 09:08:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 7 months ago (2016-05-20 11:09:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998183002/1
4 years, 7 months ago (2016-05-20 11:31:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-20 13:31:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998183002/1
4 years, 7 months ago (2016-05-20 13:50:32 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 15:42:27 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 15:42:37 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cac94aae3e2eb749658c978f198e1ca7627ae972
Cr-Commit-Position: refs/heads/master@{#12831}

Powered by Google App Engine
This is Rietveld 408576698