Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1992813006: Fix bug in gyp_webrtc.py when DEPOT_TOOLS_WIN_TOOLCHAIN=0 (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix bug in gyp_webrtc.py when DEPOT_TOOLS_WIN_TOOLCHAIN=0 In https://codereview.webrtc.org/1895713002 a bug was introduced in order to satisfy the PyLint check. BUG=webrtc:5911 NOTRY=True R=phoglund@webrtc.org Committed: https://crrev.com/0026dd85de39e424330637edc740ed7ef149d561 Cr-Commit-Position: refs/heads/master@{#12810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/build/gyp_webrtc.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
4 years, 7 months ago (2016-05-19 11:20:09 UTC) #2
phoglund
lgtm
4 years, 7 months ago (2016-05-19 11:22:56 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0026dd85de39e424330637edc740ed7ef149d561 Cr-Commit-Position: refs/heads/master@{#12810}
4 years, 7 months ago (2016-05-19 11:30:19 UTC) #7
kjellander_webrtc
4 years, 7 months ago (2016-05-19 11:30:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0026dd85de39e424330637edc740ed7ef149d561.

Powered by Google App Engine
This is Rietveld 408576698