Move logic of gyp_webrtc into gyp_webrtc.py

Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

R=phoglund@webrtc.org
TBR=tkchin@webrtc.org

Committed: https://crrev.com/001c20dd47183823192a9b6bc1e3f7dc3f324648
Cr-Commit-Position: refs/heads/master@{#12410}

[kjellander_webrtc, 2016-04-18 07:28:51]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.

Similar Chromium CL: https://codereview.chromium.org/1216863010
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010
==========

[kjellander_webrtc, 2016-04-18 07:28:51]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[kjellander_webrtc, 2016-04-18 07:29:58]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-04-18 07:31:34]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-04-18 07:37:04]

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.py
File webrtc/build/gyp_webrtc.py (right):

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:11: # This script is used to run GYP for WebRTC. It
contains selected parts of the
The diff is not every readable since both files existed before.

Here's the interesting parts to ease review:
https://www.diffchecker.com/upbuveoc

[kjellander_webrtc, 2016-04-18 07:37:42]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Benefits with this
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.
==========

[kjellander_webrtc, 2016-04-18 07:37:58]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Benefits with this
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.
==========

[phoglund, 2016-04-18 08:24:25]

lgtm

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.py
File webrtc/build/gyp_webrtc.py (right):

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:31: def GetSupplementalFiles():
Nit: two blank lines

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:32: """Returns a list of the supplemental files that
are included in all GYP
Nit: """Complete one-line sentence.

More info that didn't fit in the one-line sentence."""

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:51: # Update the environment based on webrtc.gyp_env
Nit: end with .

[kjellander_webrtc, 2016-04-18 08:46:45]

Fixed nits. Will deploy later today when I have time to monitor the bots.

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.py
File webrtc/build/gyp_webrtc.py (right):

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:31: def GetSupplementalFiles():
On 2016/04/18 08:24:25, phoglund wrote:
> Nit: two blank lines

Done.

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:32: """Returns a list of the supplemental files that
are included in all GYP
On 2016/04/18 08:24:24, phoglund wrote:
> Nit: """Complete one-line sentence.
> 
> More info that didn't fit in the one-line sentence."""

Done.

https://codereview.webrtc.org/1895713002/diff/40001/webrtc/build/gyp_webrtc.p...
webrtc/build/gyp_webrtc.py:51: # Update the environment based on webrtc.gyp_env
On 2016/04/18 08:24:25, phoglund wrote:
> Nit: end with .

Done.

[kjellander_webrtc, 2016-04-18 11:25:29]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

TBR=tkchin@webrtc.org
==========

[kjellander_webrtc, 2016-04-18 11:25:29]

kjellander@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[kjellander_webrtc, 2016-04-18 11:26:03]

TBRing tkchin regarding the small bugfix in 	webrtc/build/ios/build_ios_libs.sh

[kjellander_webrtc, 2016-04-18 11:55:52]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Remove 'DEPOT_TOOLS_WIN_TOOLCHAIN' environmental variable
  check since it's done inside vs_toolchain.py.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

TBR=tkchin@webrtc.org
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

TBR=tkchin@webrtc.org
==========

[kjellander_webrtc, 2016-04-18 11:58:04]

On 2016/04/18 11:26:03, kjellander (webrtc) wrote:
> TBRing tkchin regarding the small bugfix in
	webrtc/build/ios/build_ios_libs.sh

Restored the Visual Studio stuff in PS#4 since I don't understand why it fails
(and it doesn't have to be done in this CL).
New diff for PS#4: https://www.diffchecker.com/fagvmx2d

[kjellander_webrtc, 2016-04-18 14:33:09]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

TBR=tkchin@webrtc.org
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

R=phoglund@webrtc.org
TBR=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/001c20dd47183823192a9b6bc...
==========

[kjellander_webrtc, 2016-04-18 14:33:10]

Committed patchset #5 (id:120001) manually as
001c20dd47183823192a9b6bc1e3f7dc3f324648 (presubmit successful).

[commit-bot: I haz the power, 2016-04-18 14:33:10]

Description was changed from

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

R=phoglund@webrtc.org
TBR=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/001c20dd47183823192a9b6bc...
==========

to

==========
Move logic of gyp_webrtc into gyp_webrtc.py

For historical reasons gyp_webrtc.py was launcher script
for gyp_webrtc and the python logic lived in the
gyp_webrtc.  This change moves python code into the
.py file makes the extension-free gyp_webrtc a launcher
for gyp_webrtc.py.

Other changes:
* Move the code into a main() function.
* Add call to disable GC to save some processing time.
* Set executable permission on gyp_webrtc.py and remove it from
  gyp_webrtc.

Similar Chromium CL: https://codereview.chromium.org/1216863010

Motivation for this change:
* Gets checked with PyLint
* Easy to add unit tests if we add our own functionality.

R=phoglund@webrtc.org
TBR=tkchin@webrtc.org

Committed: https://crrev.com/001c20dd47183823192a9b6bc1e3f7dc3f324648
Cr-Commit-Position: refs/heads/master@{#12410}
==========

[commit-bot: I haz the power, 2016-04-18 14:33:11]

Patchset 5 (id:??) landed as
https://crrev.com/001c20dd47183823192a9b6bc1e3f7dc3f324648
Cr-Commit-Position: refs/heads/master@{#12410}