Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: webrtc/modules/video_coding/frame_object.h

Issue 1988653002: PacketBuffer now can save how many times a packet has been nacked. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/frame_object.h
diff --git a/webrtc/modules/video_coding/frame_object.h b/webrtc/modules/video_coding/frame_object.h
index 80ab0ec4ff7daa234328f5c8b4d8997bfa3e7ba6..57ec7dfe2656829d748c0f8eeaa3d71394732c62 100644
--- a/webrtc/modules/video_coding/frame_object.h
+++ b/webrtc/modules/video_coding/frame_object.h
@@ -35,6 +35,8 @@ class FrameObject {
size_t num_references;
uint16_t references[kMaxFrameReferences];
bool inter_layer_predicted;
+
+ size_t size;
};
class PacketBuffer;
@@ -43,11 +45,14 @@ class RtpFrameObject : public FrameObject {
public:
RtpFrameObject(PacketBuffer* packet_buffer,
uint16_t first_seq_num,
- uint16_t last_seq_num);
+ uint16_t last_seq_num,
+ size_t combined_size,
+ int8_t max_nack_count);
~RtpFrameObject();
uint16_t first_seq_num() const;
uint16_t last_seq_num() const;
+ int8_t max_nack_count() const;
FrameType frame_type() const;
VideoCodecType codec_type() const;
bool GetBitstream(uint8_t* destination) const override;
@@ -59,6 +64,7 @@ class RtpFrameObject : public FrameObject {
VideoCodecType codec_type_;
uint16_t first_seq_num_;
uint16_t last_seq_num_;
+ int8_t max_nack_count_;
stefan-webrtc 2016/05/20 13:10:23 Why int8_t? int would be nicer
philipel 2016/05/23 09:19:22 Changed to int. The reason I use int8_t here is b
terelius 2016/05/23 11:49:55 If you keep this as an int8_t and you are going to
};
} // namespace video_coding
« no previous file with comments | « no previous file | webrtc/modules/video_coding/frame_object.cc » ('j') | webrtc/modules/video_coding/packet_buffer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698