Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: webrtc/modules/video_coding/packet_buffer.h

Issue 1988653002: PacketBuffer now can save how many times a packet has been nacked. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/packet_buffer.h
diff --git a/webrtc/modules/video_coding/packet_buffer.h b/webrtc/modules/video_coding/packet_buffer.h
index ae0916a75f3bfb4f099f2ea730dbc6d0bd2379a2..6d054a5677b52e2499c27da98ccc9dc3480b0a33 100644
--- a/webrtc/modules/video_coding/packet_buffer.h
+++ b/webrtc/modules/video_coding/packet_buffer.h
@@ -39,7 +39,7 @@ class PacketBuffer {
size_t max_buffer_size,
OnCompleteFrameCallback* frame_callback);
- bool InsertPacket(const VCMPacket& packet);
+ bool InsertPacket(const VCMPacket& packet, int times_nacked = -1);
stefan-webrtc 2016/05/20 13:10:23 Avoid default arguments. Maybe add a nacked member
philipel 2016/05/23 09:19:22 Done.
void ClearTo(uint16_t seq_num);
void Clear();
@@ -66,6 +66,9 @@ class PacketBuffer {
// If this packet has been used to create a frame already.
bool frame_created = false;
+
+ // How many times this packet has been Nacked.
+ uint8_t times_nacked = 0;
};
// Tries to expand the buffer.

Powered by Google App Engine
This is Rietveld 408576698