PacketBuffer now can save how many times a packet has been nacked.

webrtc/modules/video_coding/frame_object.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 17 matching lines @@
 
   // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame
   // object. For codec types that don't necessarily have picture ids they
   // have to be constructed from the header data relevant to that codec.
   uint16_t picture_id;
   uint8_t spatial_layer;
 
   size_t num_references;
   uint16_t references[kMaxFrameReferences];
   bool inter_layer_predicted;
+
+  size_t size;
 };
 
 class PacketBuffer;
 
 class RtpFrameObject : public FrameObject {
  public:
   RtpFrameObject(PacketBuffer* packet_buffer,
                  uint16_t first_seq_num,
-                 uint16_t last_seq_num);
+                 uint16_t last_seq_num,
+                 size_t combined_size,
+                 int8_t max_nack_count);
 
   ~RtpFrameObject();
   uint16_t first_seq_num() const;
   uint16_t last_seq_num() const;
+  int8_t max_nack_count() const;
   FrameType frame_type() const;
   VideoCodecType codec_type() const;
   bool GetBitstream(uint8_t* destination) const override;
   RTPVideoTypeHeader* GetCodecHeader() const;
 
  private:
   PacketBuffer* packet_buffer_;
   FrameType frame_type_;
   VideoCodecType codec_type_;
   uint16_t first_seq_num_;
   uint16_t last_seq_num_;
+  int8_t max_nack_count_;

[stefan-webrtc, 2016/05/20 13:10:23]

Why int8_t? int would be nicer

[philipel, 2016/05/23 09:19:22]

Changed to int.

The reason I use int8_t here is because a FrameObject is something we might
potentially have many instances of and therefore size might make a difference.

[terelius, 2016/05/23 11:49:55]

If you keep this as an int8_t and you are going to (semi-implicitly) cast the
ints to int8_t, I think would be better to have int8_t everywhere.

 };
 
 }  // namespace video_coding
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_