NetEq: Replace timescale_holdoff_ with a Countdown timer

NetEq: Replace timescale_holdoff_ with a Countdown timer

The timescale_holdoff_ is a counter in the DecisionLogic class. The
purpose is to enforce a minimum number of GetAudio calls
between (successfull) time-scaling operations (i.e., Accelerate and
Pre-emptive Expand operations). With this change, the counter is
replaced with a Countdown timer obtained from a TickTimer object.

BUG=webrtc:5608
R=tina.legrand@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/47b17dc59c073768992c3a7ec085ada608953ed6

[hlundin-webrtc, 2016-05-03 19:03:54]

Patchset #1 (id:1) has been deleted

[hlundin-webrtc, 2016-05-03 19:09:10]

henrik.lundin@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[hlundin-webrtc, 2016-05-03 19:09:11]

CL #7 (out of 8 for the TickTimer feature). PTAL. Thanks!

https://codereview.webrtc.org/1945863002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/decision_logic.cc (right):

https://codereview.webrtc.org/1945863002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/decision_logic.cc:93:
tick_timer_->GetNewCountdown(kMinTimescaleInterval + 1);
The +1 here is for bit-exactness with the old code. The SoftReset is called from
another place in the code.

https://codereview.webrtc.org/1945863002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/decision_logic.h (right):

https://codereview.webrtc.org/1945863002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/decision_logic.h:117: static const int
kMinTimescaleInterval = 5;
The change from 6 to 5 is motivated by the fact that the TickTimer is
incremented before the Countdown timer timescale_countdown_ is checked, while in
the old code the timescale_hold_off_ value was decreased after checking it.

[tlegrand-webrtc, 2016-05-10 05:55:33]

lgtm

https://codereview.webrtc.org/1945863002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/decision_logic.cc (right):

https://codereview.webrtc.org/1945863002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/decision_logic.cc:93:
tick_timer_->GetNewCountdown(kMinTimescaleInterval + 1);
On 2016/05/03 19:09:10, hlundin-webrtc wrote:
> The +1 here is for bit-exactness with the old code. The SoftReset is called
from
> another place in the code.

Acknowledged.

[hlundin-webrtc, 2016-05-10 06:57:56]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-05-10 06:58:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945863002/20001

[commit-bot: I haz the power, 2016-05-10 07:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 07:12:58]

Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[commit-bot: I haz the power, 2016-05-10 08:21:17]

Description was changed from

==========
NetEq: Replace timescale_holdoff_ with a Countdown timer

The timescale_holdoff_ is a counter in the DecisionLogic class. The
purpose is to enforce a minimum number of GetAudio calls
between (successfull) time-scaling operations (i.e., Accelerate and
Pre-emptive Expand operations). With this change, the counter is
replaced with a Countdown timer obtained from a TickTimer object.

BUG=webrtc:5608
==========

to

==========
NetEq: Replace timescale_holdoff_ with a Countdown timer

The timescale_holdoff_ is a counter in the DecisionLogic class. The
purpose is to enforce a minimum number of GetAudio calls
between (successfull) time-scaling operations (i.e., Accelerate and
Pre-emptive Expand operations). With this change, the counter is
replaced with a Countdown timer obtained from a TickTimer object.

BUG=webrtc:5608
R=tina.legrand@webrtc.org

Committed: https://crrev.com/47b17dc59c073768992c3a7ec085ada608953ed6
Cr-Commit-Position: refs/heads/master@{#12670}
==========

[commit-bot: I haz the power, 2016-05-10 08:21:18]

Patchset 1 (id:??) landed as
https://crrev.com/47b17dc59c073768992c3a7ec085ada608953ed6
Cr-Commit-Position: refs/heads/master@{#12670}

[hlundin-webrtc, 2016-05-10 08:21:20]

Description was changed from

==========
NetEq: Replace timescale_holdoff_ with a Countdown timer

The timescale_holdoff_ is a counter in the DecisionLogic class. The
purpose is to enforce a minimum number of GetAudio calls
between (successfull) time-scaling operations (i.e., Accelerate and
Pre-emptive Expand operations). With this change, the counter is
replaced with a Countdown timer obtained from a TickTimer object.

BUG=webrtc:5608
R=tina.legrand@webrtc.org

Committed: https://crrev.com/47b17dc59c073768992c3a7ec085ada608953ed6
Cr-Commit-Position: refs/heads/master@{#12670}
==========

to

==========
NetEq: Replace timescale_holdoff_ with a Countdown timer

The timescale_holdoff_ is a counter in the DecisionLogic class. The
purpose is to enforce a minimum number of GetAudio calls
between (successfull) time-scaling operations (i.e., Accelerate and
Pre-emptive Expand operations). With this change, the counter is
replaced with a Countdown timer obtained from a TickTimer object.

BUG=webrtc:5608
R=tina.legrand@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/47b17dc59c073768992c3a7ec...
==========

[hlundin-webrtc, 2016-05-10 08:21:21]

Committed patchset #1 (id:20001) manually as
47b17dc59c073768992c3a7ec085ada608953ed6 (presubmit successful).