NetEq: Replace timescale_holdoff_ with a Countdown timer

webrtc/modules/audio_coding/neteq/decision_logic.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 11 matching lines @@
 #include "webrtc/system_wrappers/include/logging.h"
 
 namespace webrtc {
 
 DecisionLogic* DecisionLogic::Create(int fs_hz,
                                      size_t output_size_samples,
                                      NetEqPlayoutMode playout_mode,
                                      DecoderDatabase* decoder_database,
                                      const PacketBuffer& packet_buffer,
                                      DelayManager* delay_manager,
-                                     BufferLevelFilter* buffer_level_filter) {
+                                     BufferLevelFilter* buffer_level_filter,
+                                     const TickTimer* tick_timer) {
   switch (playout_mode) {
     case kPlayoutOn:
     case kPlayoutStreaming:
-      return new DecisionLogicNormal(fs_hz,
-                                     output_size_samples,
-                                     playout_mode,
-                                     decoder_database,
-                                     packet_buffer,
-                                     delay_manager,
-                                     buffer_level_filter);
+      return new DecisionLogicNormal(
+          fs_hz, output_size_samples, playout_mode, decoder_database,
+          packet_buffer, delay_manager, buffer_level_filter, tick_timer);
     case kPlayoutFax:
     case kPlayoutOff:
-      return new DecisionLogicFax(fs_hz,
-                                  output_size_samples,
-                                  playout_mode,
-                                  decoder_database,
-                                  packet_buffer,
-                                  delay_manager,
-                                  buffer_level_filter);
+      return new DecisionLogicFax(
+          fs_hz, output_size_samples, playout_mode, decoder_database,
+          packet_buffer, delay_manager, buffer_level_filter, tick_timer);
   }
   // This line cannot be reached, but must be here to avoid compiler errors.
   assert(false);
   return NULL;
 }
 
 DecisionLogic::DecisionLogic(int fs_hz,
                              size_t output_size_samples,
                              NetEqPlayoutMode playout_mode,
                              DecoderDatabase* decoder_database,
                              const PacketBuffer& packet_buffer,
                              DelayManager* delay_manager,
-                             BufferLevelFilter* buffer_level_filter)
+                             BufferLevelFilter* buffer_level_filter,
+                             const TickTimer* tick_timer)
     : decoder_database_(decoder_database),
       packet_buffer_(packet_buffer),
       delay_manager_(delay_manager),
       buffer_level_filter_(buffer_level_filter),
+      tick_timer_(tick_timer),
       cng_state_(kCngOff),
       packet_length_samples_(0),
       sample_memory_(0),
       prev_time_scale_(false),
-      timescale_hold_off_(kMinTimescaleInterval),
+      timescale_countdown_(
+          tick_timer_->GetNewCountdown(kMinTimescaleInterval + 1)),
       num_consecutive_expands_(0),
       playout_mode_(playout_mode) {
   delay_manager_->set_streaming_mode(playout_mode_ == kPlayoutStreaming);
   SetSampleRate(fs_hz, output_size_samples);
 }
 
+DecisionLogic::~DecisionLogic() = default;
+
 void DecisionLogic::Reset() {
   cng_state_ = kCngOff;
   noise_fast_forward_ = 0;
   packet_length_samples_ = 0;
   sample_memory_ = 0;
   prev_time_scale_ = false;
-  timescale_hold_off_ = 0;
+  timescale_countdown_.reset();
   num_consecutive_expands_ = 0;
 }
 
 void DecisionLogic::SoftReset() {
   packet_length_samples_ = 0;
   sample_memory_ = 0;
   prev_time_scale_ = false;
-  timescale_hold_off_ = kMinTimescaleInterval;
+  timescale_countdown_ =
+      tick_timer_->GetNewCountdown(kMinTimescaleInterval + 1);

[hlundin-webrtc, 2016/05/03 19:09:10]

The +1 here is for bit-exactness with the old code. The SoftReset is called from
another place in the code.

[tlegrand-webrtc, 2016/05/10 05:55:33]

Acknowledged.

 }
 
 void DecisionLogic::SetSampleRate(int fs_hz, size_t output_size_samples) {
   // TODO(hlundin): Change to an enumerator and skip assert.
   assert(fs_hz == 8000 || fs_hz == 16000 || fs_hz ==  32000 || fs_hz == 48000);
   fs_mult_ = fs_hz / 8000;
   output_size_samples_ = output_size_samples;
 }
 
 Operations DecisionLogic::GetDecision(const SyncBuffer& sync_buffer,
@@ skipping 53 matching lines @@
         delay_manager_->base_target_level());
 
     size_t buffer_size_packets = 0;
     if (packet_length_samples_ > 0) {
       // Calculate size in packets.
       buffer_size_packets = buffer_size_samples / packet_length_samples_;
     }
     int sample_memory_local = 0;
     if (prev_time_scale_) {
       sample_memory_local = sample_memory_;
-      timescale_hold_off_ = kMinTimescaleInterval;
+      timescale_countdown_ =
+          tick_timer_->GetNewCountdown(kMinTimescaleInterval);
     }
     buffer_level_filter_->Update(buffer_size_packets, sample_memory_local,
                                  packet_length_samples_);
     prev_time_scale_ = false;
   }
-
-  timescale_hold_off_ = std::max(timescale_hold_off_ - 1, 0);
 }
 
 }  // namespace webrtc