Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1948663002: NetEq: Update stats earlier in the GetAudioInternal call (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@timescale-holdoff
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Update stats earlier in the GetAudioInternal call This is to prepare for implementation of NetEq muted state, which may cause GetAudioInternal to make an early return just before the call to GetDecision. With this change, the stats are updated in any case. BUG=webrtc:5608 NOTRY=True Committed: https://crrev.com/60f6ce2a29cf72d9a1ec7bdf0fa947a2b25cba07 Cr-Commit-Position: refs/heads/master@{#12671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
hlundin-webrtc
The last (and smallest) CL for the TickTimer feature. PTAL. Thanks!
4 years, 7 months ago (2016-05-03 19:10:46 UTC) #2
tlegrand-webrtc
Nice! LGTM
4 years, 7 months ago (2016-05-10 08:19:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948663002/1
4 years, 7 months ago (2016-05-10 08:22:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3841)
4 years, 7 months ago (2016-05-10 08:51:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948663002/1
4 years, 7 months ago (2016-05-10 10:50:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 10:52:10 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 10:52:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60f6ce2a29cf72d9a1ec7bdf0fa947a2b25cba07
Cr-Commit-Position: refs/heads/master@{#12671}

Powered by Google App Engine
This is Rietveld 408576698