Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1944743002: Revert of Enable -Winconsistent-missing-override flag. (Closed)

Created:
4 years, 7 months ago by ivoc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, video-team_agora.io, hlundin-webrtc, yujie_mao (webrtc), kwiberg-webrtc, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://codereview.webrtc.org/1921653002/ ) Reason for revert: This CL breaks the google3 import (but not the import bot). Original issue's description: > Enable -Winconsistent-missing-override flag. > > The problem with gmock is worked around by commenting out any other override declarations in classes using gmock. > > NOPRESUBMIT=True > BUG=webrtc:3970 > > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60 > Cr-Commit-Position: refs/heads/master@{#12563} TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:3970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -232 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/dtmfsender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/dtmfsender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/mediastream.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectionfactory.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/rtpsender.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M webrtc/api/statscollector_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/test/fakedtlsidentitystore.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/videotrack.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/api/videotracksource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/webrtcsession.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/callback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/fakesslidentity.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/base/rtccertificategenerator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/i420_buffer_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/fakemediaengine.h View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideoengine.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/isac_speed_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_speed_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_isac_quality_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/include/mock/mock_process_thread.h View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.h View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 chunk +7 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/mock_voice_engine.h View 3 chunks +2 lines, -7 lines 0 comments Download
M webrtc/test/rtp_file_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/overuse_frame_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_channel.h View 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
ivoc
Created Revert of Enable -Winconsistent-missing-override flag.
4 years, 7 months ago (2016-05-03 14:43:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-03 14:43:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-03 15:02:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-03 15:32:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-03 16:02:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-03 16:32:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-03 16:43:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-04 07:25:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5279)
4 years, 7 months ago (2016-05-04 07:27:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944743002/1
4 years, 7 months ago (2016-05-04 07:29:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5281)
4 years, 7 months ago (2016-05-04 07:33:09 UTC) #16
mflodman
This might beed a rebase and resolve some conflicts, e.g. has vie_channel.h been renamed to ...
4 years, 7 months ago (2016-05-06 08:18:31 UTC) #17
ivoc
On 2016/05/06 08:18:31, mflodman wrote: > This might beed a rebase and resolve some conflicts, ...
4 years, 7 months ago (2016-05-06 09:18:55 UTC) #18
mflodman
4 years, 7 months ago (2016-05-06 10:22:18 UTC) #19 
On 2016/05/06 09:18:55, ivoc wrote:
> On 2016/05/06 08:18:31, mflodman wrote:
> > This might beed a rebase and resolve some conflicts, e.g. has vie_channel.h
> been
> > renamed to video_stream_decoder.h.
> 
> I decided to go for a partial revert instead, see
> https://codereview.webrtc.org/1944273002/

Ah, ok. Can you mark this CL as closed then?

Powered by Google App Engine
This is Rietveld 408576698