webrtc/api/webrtcsession.h - Issue 1944743002: Revert of Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession.h

Issue 1944743002: Revert of Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsession.h

diff --git a/webrtc/api/webrtcsession.h b/webrtc/api/webrtcsession.h

index 970f967cb8da595197389321cff79269c8577352..89b77bbc884b34950b83fc78ea45b050690fadb4 100644

--- a/webrtc/api/webrtcsession.h

+++ b/webrtc/api/webrtcsession.h

@@ -267,10 +267,10 @@

const RtpParameters& parameters) override;

// Implements DtmfProviderInterface.

- bool CanInsertDtmf(const std::string& track_id) override;

- bool InsertDtmf(const std::string& track_id,

- int code, int duration) override;

- sigslot::signal0<>* GetOnDestroyedSignal() override;

+ virtual bool CanInsertDtmf(const std::string& track_id);

+ virtual bool InsertDtmf(const std::string& track_id,

+ int code, int duration);

+ virtual sigslot::signal0<>* GetOnDestroyedSignal();

// Implements DataChannelProviderInterface.

bool SendData(const cricket::SendDataParams& params,

« no previous file with comments | « webrtc/api/videotracksource.h ('k') | webrtc/api/webrtcsession_unittest.cc » ('j') | no next file with comments »