Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: webrtc/modules/utility/source/file_recorder_impl.h

Issue 1944743002: Revert of Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/utility/source/file_recorder_impl.h
diff --git a/webrtc/modules/utility/source/file_recorder_impl.h b/webrtc/modules/utility/source/file_recorder_impl.h
index 44169cc267e28546d514a4e3b33de9c99fb9a6d3..697d759375708b83c2bd66bead3a05fa958288f2 100644
--- a/webrtc/modules/utility/source/file_recorder_impl.h
+++ b/webrtc/modules/utility/source/file_recorder_impl.h
@@ -45,23 +45,23 @@
virtual ~FileRecorderImpl();
// FileRecorder functions.
- int32_t RegisterModuleFileCallback(FileCallback* callback) override;
- FileFormats RecordingFileFormat() const override;
- int32_t StartRecordingAudioFile(
+ virtual int32_t RegisterModuleFileCallback(FileCallback* callback);
+ virtual FileFormats RecordingFileFormat() const;
+ virtual int32_t StartRecordingAudioFile(
const char* fileName,
const CodecInst& codecInst,
uint32_t notificationTimeMs) override;
- int32_t StartRecordingAudioFile(
+ virtual int32_t StartRecordingAudioFile(
OutStream& destStream,
const CodecInst& codecInst,
uint32_t notificationTimeMs) override;
- int32_t StopRecording() override;
- bool IsRecording() const override;
- int32_t codec_info(CodecInst& codecInst) const override;
- int32_t RecordAudioToFile(
+ virtual int32_t StopRecording();
+ virtual bool IsRecording() const;
+ virtual int32_t codec_info(CodecInst& codecInst) const;
+ virtual int32_t RecordAudioToFile(
const AudioFrame& frame,
- const TickTime* playoutTS = NULL) override;
- int32_t StartRecordingVideoFile(
+ const TickTime* playoutTS = NULL);
+ virtual int32_t StartRecordingVideoFile(
const char* fileName,
const CodecInst& audioCodecInst,
const VideoCodec& videoCodecInst,
@@ -69,7 +69,7 @@
{
return -1;
}
- int32_t RecordVideoToFile(const VideoFrame& videoFrame) override {
+ virtual int32_t RecordVideoToFile(const VideoFrame& videoFrame) {
return -1;
}

Powered by Google App Engine
This is Rietveld 408576698