Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1934723003: Stop QuicDataChannel and QuicDataTransport unit tests from segfaulting (Closed)

Created:
4 years, 7 months ago by mikescarlett
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Stop QuicDataChannel and QuicDataTransport unit tests from segfaulting Minor; needed because QuicTransportChannel now owns the ICE transport channel as a result of the QuicTransport CL. TBR=pthatcher@webrtc.org BUG= Committed: https://crrev.com/a97611a43f303cee941794e1cb240d9e33160cc0 Cr-Commit-Position: refs/heads/master@{#12576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M webrtc/api/quicdatachannel_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/api/quicdatatransport_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934723003/1
4 years, 7 months ago (2016-04-30 04:11:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-30 05:09:32 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:23 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a97611a43f303cee941794e1cb240d9e33160cc0
Cr-Commit-Position: refs/heads/master@{#12576}

Powered by Google App Engine
This is Rietveld 408576698