Stop QuicDataChannel and QuicDataTransport unit tests from segfaulting

webrtc/api/quicdatatransport_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 46 matching lines @@
  private:
   std::vector<std::string> messages_;
 };
 
 // A peer who uses a QUIC transport channel and fake ICE transport channel to
 // send or receive data.
 class QuicDataTransportPeer {
  public:
   QuicDataTransportPeer()
       : quic_data_transport_(rtc::Thread::Current(), rtc::Thread::Current()),
-        ice_transport_channel_("data", 0),
-        quic_transport_channel_(&ice_transport_channel_) {
-    ice_transport_channel_.SetAsync(true);
+        ice_transport_channel_(new FakeTransportChannel("data", 0)),
+        quic_transport_channel_(ice_transport_channel_) {
+    ice_transport_channel_->SetAsync(true);
   }
 
   void GenerateCertificateAndFingerprint() {
     rtc::scoped_refptr<rtc::RTCCertificate> local_cert =
         rtc::RTCCertificate::Create(rtc::scoped_ptr<rtc::SSLIdentity>(
             rtc::SSLIdentity::Generate("cert_name", rtc::KT_DEFAULT)));
     quic_transport_channel_.SetLocalCertificate(local_cert);
     local_fingerprint_.reset(CreateFingerprint(local_cert.get()));
   }
 
   // Connects |ice_transport_channel_| to that of the other peer.
   void Connect(QuicDataTransportPeer* other_peer) {
-    ice_transport_channel_.Connect();
-    other_peer->ice_transport_channel_.Connect();
-    ice_transport_channel_.SetDestination(&other_peer->ice_transport_channel_);
+    ice_transport_channel_->Connect();
+    other_peer->ice_transport_channel_->Connect();
+    ice_transport_channel_->SetDestination(other_peer->ice_transport_channel_);
   }
 
   rtc::scoped_ptr<rtc::SSLFingerprint>& local_fingerprint() {
     return local_fingerprint_;
   }
 
   QuicTransportChannel* quic_transport_channel() {
     return &quic_transport_channel_;
   }
 
@@ skipping 20 matching lines @@
   // Creates a fingerprint from a certificate.
   rtc::SSLFingerprint* CreateFingerprint(rtc::RTCCertificate* cert) {
     std::string digest_algorithm;
     cert->ssl_certificate().GetSignatureDigestAlgorithm(&digest_algorithm);
     rtc::scoped_ptr<rtc::SSLFingerprint> fingerprint(
         rtc::SSLFingerprint::Create(digest_algorithm, cert->identity()));
     return fingerprint.release();
   }
 
   QuicDataTransport quic_data_transport_;
-  FakeTransportChannel ice_transport_channel_;
+  FakeTransportChannel* ice_transport_channel_;
   QuicTransportChannel quic_transport_channel_;
   rtc::scoped_ptr<rtc::SSLFingerprint> local_fingerprint_;
 };
 
 class QuicDataTransportTest : public testing::Test {
  public:
   QuicDataTransportTest() {}
 
   void ConnectTransportChannels() {
     SetCryptoParameters();
@@ skipping 210 matching lines @@
   QuicTransportChannel* transport_channel = peer1_.quic_transport_channel();
   EXPECT_TRUE(quic_data_transport->SetTransportChannel(transport_channel));
   EXPECT_TRUE(quic_data_transport->SetTransportChannel(transport_channel));
   QuicTransportChannel* other_transport_channel =
       peer2_.quic_transport_channel();
   EXPECT_FALSE(
       quic_data_transport->SetTransportChannel(other_transport_channel));
 }
 
 }  // namespace