Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: webrtc/api/quicdatatransport_unittest.cc

Issue 1934723003: Stop QuicDataChannel and QuicDataTransport unit tests from segfaulting (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/quicdatachannel_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/quicdatatransport_unittest.cc
diff --git a/webrtc/api/quicdatatransport_unittest.cc b/webrtc/api/quicdatatransport_unittest.cc
index 312e825ac464ce97a6736289a597a28acf92ffda..ef9af36b852882fb6fd76990d563518432e65f54 100644
--- a/webrtc/api/quicdatatransport_unittest.cc
+++ b/webrtc/api/quicdatatransport_unittest.cc
@@ -64,9 +64,9 @@ class QuicDataTransportPeer {
public:
QuicDataTransportPeer()
: quic_data_transport_(rtc::Thread::Current(), rtc::Thread::Current()),
- ice_transport_channel_("data", 0),
- quic_transport_channel_(&ice_transport_channel_) {
- ice_transport_channel_.SetAsync(true);
+ ice_transport_channel_(new FakeTransportChannel("data", 0)),
+ quic_transport_channel_(ice_transport_channel_) {
+ ice_transport_channel_->SetAsync(true);
}
void GenerateCertificateAndFingerprint() {
@@ -79,9 +79,9 @@ class QuicDataTransportPeer {
// Connects |ice_transport_channel_| to that of the other peer.
void Connect(QuicDataTransportPeer* other_peer) {
- ice_transport_channel_.Connect();
- other_peer->ice_transport_channel_.Connect();
- ice_transport_channel_.SetDestination(&other_peer->ice_transport_channel_);
+ ice_transport_channel_->Connect();
+ other_peer->ice_transport_channel_->Connect();
+ ice_transport_channel_->SetDestination(other_peer->ice_transport_channel_);
}
rtc::scoped_ptr<rtc::SSLFingerprint>& local_fingerprint() {
@@ -122,7 +122,7 @@ class QuicDataTransportPeer {
}
QuicDataTransport quic_data_transport_;
- FakeTransportChannel ice_transport_channel_;
+ FakeTransportChannel* ice_transport_channel_;
QuicTransportChannel quic_transport_channel_;
rtc::scoped_ptr<rtc::SSLFingerprint> local_fingerprint_;
};
« no previous file with comments | « webrtc/api/quicdatachannel_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698