Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1923903002: Reland of Delete cricket::VideoFrame methods GetYPlane and GetYPitch. (Closed)

Created:
4 years, 7 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete cricket::VideoFrame methods GetYPlane and GetYPitch. (patchset #1 id:1 of https://codereview.webrtc.org/1921493004/ ) Reason for revert: Chrome has been updated, cl https://codereview.chromium.org/1919283005/ Original issue's description: > Revert of Delete cricket::VideoFrame methods GetYPlane and GetYPitch. (patchset #5 id:80001 of https://codereview.webrtc.org/1901973002/ ) > > Reason for revert: > GetYPlane, GetYPitch etc is used by Chromium. > > Original issue's description: > > Delete cricket::VideoFrame methods GetYPlane and GetYPitch. > > > > (And similarly for U and V). Also change video_frame_buffer method to > > return a const ref to a scoped_ref_ptr. > > > > This cl is analogous to https://codereview.webrtc.org/1900673002/, > > which delete corresponding methods in webrtc::VideoFrame. > > > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599 > > Cr-Commit-Position: refs/heads/master@{#12492} > > TBR=magjed@webrtc.org,perkj@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,nisse@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/b05f994bb6f3055c852891c8acb531aee916a668 > Cr-Commit-Position: refs/heads/master@{#12494} TBR=magjed@webrtc.org,perkj@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,terelius@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5682 Committed: https://crrev.com/05654518209a66ea6b4c6de2a1ae757d40c5adb5 Cr-Commit-Position: refs/heads/master@{#12559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -204 lines) Patch
M talk/app/webrtc/objc/RTCI420Frame.mm View 1 chunk +18 lines, -9 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCI420Frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/base/videoframe.h View 2 chunks +2 lines, -14 lines 0 comments Download
M webrtc/media/base/videoframe.cc View 7 chunks +35 lines, -23 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 19 chunks +126 lines, -84 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +1 line, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 4 chunks +16 lines, -47 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
nisse-webrtc
Created Reland of Delete cricket::VideoFrame methods GetYPlane and GetYPitch.
4 years, 7 months ago (2016-04-27 12:09:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923903002/1
4 years, 7 months ago (2016-04-27 12:10:48 UTC) #3
terelius
lgtm
4 years, 7 months ago (2016-04-27 12:12:07 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/2853)
4 years, 7 months ago (2016-04-27 12:24:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923903002/1
4 years, 7 months ago (2016-04-27 12:46:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-04-27 14:11:25 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923903002/1
4 years, 7 months ago (2016-04-29 08:11:15 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/2913)
4 years, 7 months ago (2016-04-29 08:43:15 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923903002/1
4 years, 7 months ago (2016-04-29 08:44:29 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/2919)
4 years, 7 months ago (2016-04-29 09:18:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923903002/1
4 years, 7 months ago (2016-04-29 09:49:40 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 09:56:06 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:49 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05654518209a66ea6b4c6de2a1ae757d40c5adb5
Cr-Commit-Position: refs/heads/master@{#12559}

Powered by Google App Engine
This is Rietveld 408576698