Chromium Code Reviews

Issue 1914893003: Re-enable Vp9FlexModeRefCount (Closed)

Created:
4 years, 8 months ago by philipel
Modified:
4 years, 7 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable Vp9FlexModeRefCount Looks like this test was disable (https://codereview.webrtc.org/1556273002) but never re-enabled after the bug was fixed. BUG=webrtc:5402 Committed: https://crrev.com/696a802332f0e70b062f496d0c869030d58e70d7 Cr-Commit-Position: refs/heads/master@{#12606}

Patch Set 1 #

Patch Set 2 : Removed commented code #

Total comments: 2

Patch Set 3 : Removed old comments. #

Unified diffs Side-by-side diffs Stats (+0 lines, -4 lines)
M webrtc/video/video_send_stream_tests.cc View 2 chunks +0 lines, -4 lines 0 comments

Messages

Total messages: 12 (5 generated)
philipel
4 years, 8 months ago (2016-04-25 12:14:18 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/1914893003/diff/20001/webrtc/video/video_send_stream_tests.cc File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/1914893003/diff/20001/webrtc/video/video_send_stream_tests.cc#newcode2285 webrtc/video/video_send_stream_tests.cc:2285: // See https://code.google.com/p/webrtc/issues/detail?id=5402. Remove these comments too?
4 years, 8 months ago (2016-04-26 11:12:20 UTC) #4
philipel
https://codereview.webrtc.org/1914893003/diff/20001/webrtc/video/video_send_stream_tests.cc File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/1914893003/diff/20001/webrtc/video/video_send_stream_tests.cc#newcode2285 webrtc/video/video_send_stream_tests.cc:2285: // See https://code.google.com/p/webrtc/issues/detail?id=5402. On 2016/04/26 11:12:19, stefan-webrtc (holmer) wrote: ...
4 years, 7 months ago (2016-05-03 09:42:30 UTC) #5
stefan-webrtc
lgtm
4 years, 7 months ago (2016-05-03 10:29:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914893003/40001
4 years, 7 months ago (2016-05-03 10:37:47 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 12:45:47 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 12:45:55 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/696a802332f0e70b062f496d0c869030d58e70d7
Cr-Commit-Position: refs/heads/master@{#12606}

Powered by Google App Engine