Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1556273002:
Roll chromium_revision 4df108a..2a70cb1 (367307:367468) (Closed)
|
Created:
4 years, 11 months ago by kjellander_webrtc Modified:
4 years, 11 months ago CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 4df108a..2a70cb1 (367307:367468)
Mac 32-bit support has been gone in Chromium for a long time, but was
removed in https://codereview.chromium.org/1557823002. This called
for finally removing our Mac 32-bit builds, which was done in
http://crbug.com/574320.
Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1
Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1
Changed dependencies:
* src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7
* src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3
DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS
No update to Clang.
TBR=marpan@webrtc.org, stefan@webrtc.org,
BUG=webrtc:5401, webrtc:5402
NOTRY=True
Committed: https://crrev.com/44cc7950160aee01889a6b5a21a384b20cfb5532
Cr-Commit-Position: refs/heads/master@{#11159}
Patch Set 1 #Patch Set 2 : Disable tests failing on Android and Linux MSan #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/11880)
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Warning changes in https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/build/commo... calls for some tweaks to our code. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, ==========
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Warning changes in https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/build/commo... calls for some tweaks to our code. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but is removed in https://codereview.chromium.org/1557823002 which hits our Mac 32-bit builds. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, ==========
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but is removed in https://codereview.chromium.org/1557823002 which hits our Mac 32-bit builds. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but is removed in https://codereview.chromium.org/1557823002 which hits our Mac 32-bit builds. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 ==========
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but is removed in https://codereview.chromium.org/1557823002 which hits our Mac 32-bit builds. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 ==========
The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556273002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, no build URL)
On 2016/01/06 19:46:23, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, no build URL) That trybot failed just because I recently renamed a few trybots when I removed the Mac 32-bit configs. I'll submit this if all other bots go green now. It should no longer be triggered after submitting https://codereview.webrtc.org/1565893003/
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556273002/20001
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 NOTRY=True ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 NOTRY=True ========== to ========== Roll chromium_revision 4df108a..2a70cb1 (367307:367468) Mac 32-bit support has been gone in Chromium for a long time, but was removed in https://codereview.chromium.org/1557823002. This called for finally removing our Mac 32-bit builds, which was done in http://crbug.com/574320. Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 Changed dependencies: * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, BUG=webrtc:5401, webrtc:5402 NOTRY=True Committed: https://crrev.com/44cc7950160aee01889a6b5a21a384b20cfb5532 Cr-Commit-Position: refs/heads/master@{#11159} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/44cc7950160aee01889a6b5a21a384b20cfb5532 Cr-Commit-Position: refs/heads/master@{#11159}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.webrtc.org/1569293002/ by guoweis@webrtc.org. The reason for reverting is: video_engine_tests video_engine_tests on Win DrMemory Full has been consistently failing after this change.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
