Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1569293002: Revert of Roll chromium_revision 4df108a..2a70cb1 (367307:367468) (Closed)

Created:
4 years, 11 months ago by guoweis_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll chromium_revision 4df108a..2a70cb1 (367307:367468) (patchset #2 id:20001 of https://codereview.webrtc.org/1556273002/ ) Reason for revert: video_engine_tests video_engine_tests on Win DrMemory Full has been consistently failing after this change. Original issue's description: > Roll chromium_revision 4df108a..2a70cb1 (367307:367468) > > Mac 32-bit support has been gone in Chromium for a long time, but was > removed in https://codereview.chromium.org/1557823002. This called > for finally removing our Mac 32-bit builds, which was done in > http://crbug.com/574320. > > Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1 > Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1 > > Changed dependencies: > * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7 > * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3 > DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS > > No update to Clang. > > TBR=marpan@webrtc.org, stefan@webrtc.org, > BUG=webrtc:5401, webrtc:5402 > NOTRY=True > > Committed: https://crrev.com/44cc7950160aee01889a6b5a21a384b20cfb5532 > Cr-Commit-Position: refs/heads/master@{#11159} TBR=marpan@webrtc.org,stefan@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5401, webrtc:5402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -30 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 3 chunks +2 lines, -21 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 4 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
guoweis_webrtc
Created Revert of Roll chromium_revision 4df108a..2a70cb1 (367307:367468)
4 years, 11 months ago (2016-01-08 17:40:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569293002/1
4 years, 11 months ago (2016-01-08 17:40:24 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/4369) ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 11 months ago (2016-01-08 17:41:29 UTC) #4
kjellander_webrtc
4 years, 11 months ago (2016-01-08 18:20:51 UTC) #5
Please file a bug and disable/exclude the tests for Dr Memory instead. What we
roll to is already in Chromium and I believe there's an updated libvpx revision
already on it's way. Marco can confirm this.

Powered by Google App Engine
This is Rietveld 408576698