Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: webrtc/video/video_send_stream_tests.cc

Issue 1914893003: Re-enable Vp9FlexModeRefCount (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed commented code Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> // max 10 #include <algorithm> // max
(...skipping 2262 matching lines...) Expand 10 before | Expand all | Expand 10 after
2273 2273
2274 void InspectHeader(const RTPVideoHeaderVP9& vp9_header) override { 2274 void InspectHeader(const RTPVideoHeaderVP9& vp9_header) override {
2275 if (frames_sent_ > kNumFramesToSend) 2275 if (frames_sent_ > kNumFramesToSend)
2276 observation_complete_.Set(); 2276 observation_complete_.Set();
2277 } 2277 }
2278 } test; 2278 } test;
2279 2279
2280 RunBaseTest(&test); 2280 RunBaseTest(&test);
2281 } 2281 }
2282 2282
2283 #if !defined(MEMORY_SANITIZER) 2283 // #if !defined(MEMORY_SANITIZER)
2284 // Fails under MemorySanitizer: 2284 // Fails under MemorySanitizer:
2285 // See https://code.google.com/p/webrtc/issues/detail?id=5402. 2285 // See https://code.google.com/p/webrtc/issues/detail?id=5402.
stefan-webrtc 2016/04/26 11:12:19 Remove these comments too?
philipel 2016/05/03 09:42:30 Done.
2286 TEST_F(VideoSendStreamTest, Vp9FlexModeRefCount) { 2286 TEST_F(VideoSendStreamTest, Vp9FlexModeRefCount) {
2287 class FlexibleMode : public Vp9HeaderObserver { 2287 class FlexibleMode : public Vp9HeaderObserver {
2288 void ModifyVideoConfigsHook( 2288 void ModifyVideoConfigsHook(
2289 VideoSendStream::Config* send_config, 2289 VideoSendStream::Config* send_config,
2290 std::vector<VideoReceiveStream::Config>* receive_configs, 2290 std::vector<VideoReceiveStream::Config>* receive_configs,
2291 VideoEncoderConfig* encoder_config) override { 2291 VideoEncoderConfig* encoder_config) override {
2292 encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; 2292 encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen;
2293 vp9_settings_.flexibleMode = true; 2293 vp9_settings_.flexibleMode = true;
2294 vp9_settings_.numberOfTemporalLayers = 1; 2294 vp9_settings_.numberOfTemporalLayers = 1;
2295 vp9_settings_.numberOfSpatialLayers = 2; 2295 vp9_settings_.numberOfSpatialLayers = 2;
2296 } 2296 }
2297 2297
2298 void InspectHeader(const RTPVideoHeaderVP9& vp9_header) override { 2298 void InspectHeader(const RTPVideoHeaderVP9& vp9_header) override {
2299 EXPECT_TRUE(vp9_header.flexible_mode); 2299 EXPECT_TRUE(vp9_header.flexible_mode);
2300 EXPECT_EQ(kNoTl0PicIdx, vp9_header.tl0_pic_idx); 2300 EXPECT_EQ(kNoTl0PicIdx, vp9_header.tl0_pic_idx);
2301 if (vp9_header.inter_pic_predicted) { 2301 if (vp9_header.inter_pic_predicted) {
2302 EXPECT_GT(vp9_header.num_ref_pics, 0u); 2302 EXPECT_GT(vp9_header.num_ref_pics, 0u);
2303 observation_complete_.Set(); 2303 observation_complete_.Set();
2304 } 2304 }
2305 } 2305 }
2306 } test; 2306 } test;
2307 2307
2308 RunBaseTest(&test); 2308 RunBaseTest(&test);
2309 } 2309 }
2310 #endif 2310 // #endif
2311 2311
2312 } // namespace webrtc 2312 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698