Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1894083002: Tune QP-based quality thresholds. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tune QP-based quality thresholds. Increases measure time for downscale back to 5 seconds, this is required to not over-react on hand-waving or quick device rotations. Also increase max thresholds for QP a bit to not overreact when quality still looks somewhat OK. Min thresholds for H264 seemed very low and are increased to be sure that we can go back up again. The window is still quite big with the increased max QP. Also changes libvpx thresholds to use the same thresholds as the encoder, they were excessively low before and wouldn't adapt on bad QPs at all before (but rely on >60% framedropping based on bitrates to go down). BUG=webrtc:5678 R=stefan@webrtc.org TBR=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2c8a2964fddb9b92c47a7868b2ef9fe95e755083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
pbos-webrtc
PTAL, hopefully the CL desc. says it all
4 years, 8 months ago (2016-04-18 09:46:29 UTC) #1
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-18 09:58:45 UTC) #3
pbos-webrtc
TBR=glaznev@ for webrtc/api owners, since we don't have ownership there. Alex let me know if ...
4 years, 8 months ago (2016-04-18 10:57:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c8a2964fddb9b92c47a7868b2ef9fe95e755083 Cr-Commit-Position: refs/heads/master@{#12403}
4 years, 8 months ago (2016-04-18 10:58:21 UTC) #9
pbos-webrtc
4 years, 8 months ago (2016-04-18 10:58:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c8a2964fddb9b92c47a7868b2ef9fe95e755083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698