webrtc/modules/video_coding/utility/quality_scaler.cc - Issue 1894083002: Tune QP-based quality thresholds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler.cc

Issue 1894083002: Tune QP-based quality thresholds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/utility/quality_scaler.cc

diff --git a/webrtc/modules/video_coding/utility/quality_scaler.cc b/webrtc/modules/video_coding/utility/quality_scaler.cc

index 42f3e287a939a559c72c85ff2ce9d73b2318a1dd..0e1f1d4248bd7e97a66542da765e12b18a3c5464 100644

--- a/webrtc/modules/video_coding/utility/quality_scaler.cc

+++ b/webrtc/modules/video_coding/utility/quality_scaler.cc

@@ -13,10 +13,10 @@ namespace webrtc {

namespace {

static const int kMinFps = 5;

-static const int kMeasureSecondsDownscale = 3;

// Threshold constant used until first downscale (to permit fast rampup).

static const int kMeasureSecondsFastUpscale = 2;

static const int kMeasureSecondsUpscale = 5;

+static const int kMeasureSecondsDownscale = 5;

static const int kFramedropPercentThreshold = 60;

static const int kHdResolutionThreshold = 700 * 500;

static const int kHdBitrateThresholdKbps = 500;