webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc - Issue 1894083002: Tune QP-based quality thresholds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 1894083002: Tune QP-based quality thresholds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

index 4ab939a4a7deaa1d0e5dd72a574c0608c2d98825..abe58e362699534047322cc096554613f7f46acc 100644

--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

@@ -604,8 +604,8 @@ int VP8EncoderImpl::InitEncode(const VideoCodec* inst,

// quality is good, but also low enough to not cause a flip-flop behavior

// (e.g. going up in resolution shouldn't give so bad quality that we should

// go back down).

- const int kLowQpThreshold = 23;

- const int kDisabledBadQpThreshold = 128;

+ const int kLowQpThreshold = 29;

+ const int kDisabledBadQpThreshold = 100;

// TODO(glaznev/sprang): consider passing codec initial bitrate to quality

// scaler to avoid starting with HD for low initial bitrates.

quality_scaler_.Init(kLowQpThreshold, kDisabledBadQpThreshold, false, 0, 0, 0,