Fix bug when the BWE times out due to no incoming packets.

Fix bug when the BWE times out due to no incoming packets.

Both InterArrival and OveruseEstimator should be timed out at the same time since otherwise the overuse filter may take a long time to converge.

BUG=webrtc:5773
Committed: https://crrev.com/1112b2bc68e6c900f56fad79fa7dc1c1796ce9e9
Cr-Commit-Position: refs/heads/master@{#12364}

[stefan-webrtc, 2016-04-14 09:38:09]

Description was changed from

==========
Improve the behavior when the BWE times out and when we have too little data to
determine the incoming bitrate.

BUG=webrtc:5773
==========

to

==========
Fix bug when the BWE times out due to no incoming packets.

Both InterArrival and OveruseEstimator should be timed out at the same time
since otherwise the overuse filter may take a long time to converge.

BUG=webrtc:5773
==========

[stefan-webrtc, 2016-04-14 09:38:18]

stefan@webrtc.org changed reviewers:
+ terelius@webrtc.org

[stefan-webrtc, 2016-04-14 09:44:34]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 09:44:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886783002/20001

[commit-bot: I haz the power, 2016-04-14 11:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 11:48:40]

Dry run: This issue passed the CQ dry run.

[terelius, 2016-04-14 11:54:28]

lgtm

https://codereview.webrtc.org/1886783002/diff/20001/webrtc/modules/remote_bit...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/1886783002/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:265:
TimeoutStreams(now_ms);
Would it be useful to DCHECK that estimator and inter_arrival has been set
somewhere around here?

[stefan-webrtc, 2016-04-14 12:47:36]

https://codereview.webrtc.org/1886783002/diff/20001/webrtc/modules/remote_bit...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/1886783002/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:265:
TimeoutStreams(now_ms);
On 2016/04/14 11:54:28, terelius wrote:
> Would it be useful to DCHECK that estimator and inter_arrival has been set
> somewhere around here?

Sure, I can do that.

[stefan-webrtc, 2016-04-14 12:49:57]

Add dchecks.

[stefan-webrtc, 2016-04-14 12:51:18]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-04-14 12:51:19]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1886783002/#ps40001 (title:
"Add dchecks.")

[commit-bot: I haz the power, 2016-04-14 12:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886783002/40001

[commit-bot: I haz the power, 2016-04-14 15:08:20]

Description was changed from

==========
Fix bug when the BWE times out due to no incoming packets.

Both InterArrival and OveruseEstimator should be timed out at the same time
since otherwise the overuse filter may take a long time to converge.

BUG=webrtc:5773
==========

to

==========
Fix bug when the BWE times out due to no incoming packets.

Both InterArrival and OveruseEstimator should be timed out at the same time
since otherwise the overuse filter may take a long time to converge.

BUG=webrtc:5773
==========

[commit-bot: I haz the power, 2016-04-14 15:08:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-14 15:08:23]

Description was changed from

==========
Fix bug when the BWE times out due to no incoming packets.

Both InterArrival and OveruseEstimator should be timed out at the same time
since otherwise the overuse filter may take a long time to converge.

BUG=webrtc:5773
==========

to

==========
Fix bug when the BWE times out due to no incoming packets.

Both InterArrival and OveruseEstimator should be timed out at the same time
since otherwise the overuse filter may take a long time to converge.

BUG=webrtc:5773

Committed: https://crrev.com/1112b2bc68e6c900f56fad79fa7dc1c1796ce9e9
Cr-Commit-Position: refs/heads/master@{#12364}
==========

[commit-bot: I haz the power, 2016-04-14 15:08:24]

Patchset 3 (id:??) landed as
https://crrev.com/1112b2bc68e6c900f56fad79fa7dc1c1796ce9e9
Cr-Commit-Position: refs/heads/master@{#12364}