webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc - Issue 1886783002: Fix bug when the BWE times out due to no incoming packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 1886783002: Fix bug when the BWE times out due to no incoming packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Add dchecks. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc ('k') | webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

index 36dff1fb2ac5dfc1cad01104bd83bbf4b6648f6f..3cf7c752a07e911bd680a3c48e0addaf57518ecb 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

@@ -23,7 +23,7 @@ const int kFeedbackIntervalMs = 50;

FullBweSender::FullBweSender(int kbps, BitrateObserver* observer, Clock* clock)

: bitrate_controller_(

BitrateController::CreateBitrateController(clock, observer)),

- rbe_(new RemoteBitrateEstimatorAbsSendTime(this, clock)),

+ rbe_(new RemoteBitrateEstimatorAbsSendTime(this)),

feedback_observer_(bitrate_controller_->CreateRtcpBandwidthObserver()),

clock_(clock),

send_time_history_(clock_, 10000),